Add API for outstanstding and overdue invoices report#539
Merged
supriya3105 merged 4 commits intodevelopfrom Jul 5, 2022
Merged
Add API for outstanstding and overdue invoices report#539supriya3105 merged 4 commits intodevelopfrom
supriya3105 merged 4 commits intodevelopfrom
Conversation
Current Code Coverage Percent of this PR:89.24 %Files having coverage below 100%
|
keshavbiswa
reviewed
Jul 4, 2022
app/controllers/internal_api/v1/reports/outstanding_overdue_invoices_controller.rb
Outdated
Show resolved
Hide resolved
| total_outstanding_amount = clients.pluck(:total_outstanding_amount).sum | ||
| total_overdue_amount = clients.pluck(:total_overdue_amount).sum | ||
| { | ||
| total_outstanding_amount:, |
Contributor
There was a problem hiding this comment.
Could we add the name key directly here instead of merging in the clients method?
spec/requests/internal_api/v1/reports/outstanding_overdue_invoices/index_spec.rb
Show resolved
Hide resolved
spec/requests/internal_api/v1/reports/outstanding_overdue_invoices/index_spec.rb
Show resolved
Hide resolved
Contributor
|
@shalapatil Please check the review comments from Keshav and resolve them as required. |
Contributor
|
@keshavbiswa Please check the review comments that have been incorporated by Shalaka. @shalapatil Please mark the resolved conversations as resolved . |
keshavbiswa
approved these changes
Jul 5, 2022
vipulnsward
pushed a commit
that referenced
this pull request
Feb 15, 2026
* Add API for outstanstding and overdue invoices report * Fix spec * fix suggested changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notion card
https://www.notion.so/saeloun/Create-API-s-for-outstanding-and-overdue-invoices-report-03baa78301bc4ea692fe54be6243444c
Summary
Preview
Type of change
Please delete options that are not relevant.
not work as expected)
How Has This Been Tested?
Checklist: