Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Create seed files for new employee details tables#541

Merged
mohinid merged 5 commits intodevelopfrom
create-seed-files-for-new-employee-details-tables
Jul 6, 2022
Merged

Create seed files for new employee details tables#541
mohinid merged 5 commits intodevelopfrom
create-seed-files-for-new-employee-details-tables

Conversation

@mohinid
Copy link
Contributor

@mohinid mohinid commented Jul 4, 2022 •
edited
Loading

Notion card

https://www.notion.so/saeloun/Create-APIs-to-add-and-view-personal-details-for-a-user-e312e4f0ceb849fda5f14eb05f8b2cf3

Summary

  1. Created seed files for new tables- addresses, devices & previous_employments
  2. Added column- "phone" to the users table.
  3. Set default "address_type" to "current"

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested on local rails console and with RSpecs

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@mohinid mohinid added the feature label Jul 4, 2022
@mohinid mohinid self-assigned this Jul 4, 2022
@mohinid
Copy link
Contributor Author

mohinid commented Jul 4, 2022

RSpec-
Finished in 2 minutes 57.9 seconds (files took 7.63 seconds to load)
795 examples, 0 failures, 4 pending

Adding SS for table verification-
Screenshot 2022-07-04 at 9 11 10 PM
Screenshot 2022-07-04 at 9 11 59 PM

keshavbiswa
keshavbiswa reviewed Jul 4, 2022
View reviewed changes
@github-actions
Copy link

github-actions bot commented Jul 5, 2022

Current Code Coverage Percent of this PR:

89.13 %

Files having coverage below 100%

Impacted Files Coverage
/lib/custom_failure.rb 80.0 %
/app/services/weekly_reminder_for_missed_entries_service.rb 31.82 %
/app/controllers/users/invitations_controller.rb 92.86 %
/app/controllers/users/sessions_controller.rb 85.71 %
/app/services/invoice_payment/checkout.rb 44.0 %
/app/services/invoice_payment/pdf_generation.rb 70.0 %
/app/controllers/internal_api/v1/payment_settings_controller.rb 93.33 %
/app/controllers/internal_api/v1/profile_controller.rb 96.88 %
/app/controllers/internal_api/v1/companies_controller.rb 95.45 %
/app/controllers/internal_api/v1/wise/recipients_controller.rb 90.0 %
/app/controllers/internal_api/v1/payments/providers_controller.rb 94.74 %
/lib/benchmarking/benchmarker.rb 0.0 %

akhilgkrishnan
akhilgkrishnan approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@akhilgkrishnan akhilgkrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mohinid mohinid merged commit 2ccca18 into develop Jul 6, 2022
@mohinid mohinid deleted the create-seed-files-for-new-employee-details-tables branch July 6, 2022 08:49
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
@akhilgkrishnan
Create seed files for new employee details tables (#541)
6d6ee67 
* add-phone-to-users-table

* set default address_type value as 'current'

* add seed files for addresses, devices and previous_employments

* add data using faker

Co-authored-by: Akhil G Krishnan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keshavbiswa keshavbiswa keshavbiswa left review comments

@akhilgkrishnan akhilgkrishnan akhilgkrishnan approved these changes

Assignees

@mohinid mohinid

Labels

feature PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mohinid @akhilgkrishnan @keshavbiswa