Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Time Entry Report Bug#548

Merged
apoorv1316 merged 3 commits intodevelopfrom
time-entry-report-issue
Jul 6, 2022
Merged

Time Entry Report Bug#548
apoorv1316 merged 3 commits intodevelopfrom
time-entry-report-issue

Conversation

@onkar-saeloun
Copy link
Contributor

@onkar-saeloun onkar-saeloun commented Jul 6, 2022

Notion card

https://www.notion.so/saeloun/Mismatch-UI-on-time-entry-reports-on-staging-4d2b06a97571435e9396ff6b32bebc33

Summary

Resolved Issue

Preview

Miru._.Time.tracking.and.invoicing.-.6.July.2022.1.mp4

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested Manually on local machine

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@onkar-saeloun onkar-saeloun added the bug Something isn't working label Jul 6, 2022
@onkar-saeloun onkar-saeloun self-assigned this Jul 6, 2022
@github-actions
Copy link

github-actions bot commented Jul 6, 2022

Current Code Coverage Percent of this PR:

89.25 %

Files having coverage below 100%

Impacted Files Coverage
/lib/custom_failure.rb 80.0 %
/app/services/weekly_reminder_for_missed_entries_service.rb 31.82 %
/app/controllers/users/invitations_controller.rb 92.86 %
/app/controllers/users/sessions_controller.rb 85.71 %
/app/services/invoice_payment/checkout.rb 44.0 %
/app/services/invoice_payment/pdf_generation.rb 70.0 %
/app/controllers/internal_api/v1/payment_settings_controller.rb 93.33 %
/app/controllers/internal_api/v1/profile_controller.rb 96.88 %
/app/controllers/internal_api/v1/companies_controller.rb 95.45 %
/app/controllers/internal_api/v1/wise/recipients_controller.rb 90.0 %
/app/controllers/internal_api/v1/payments/providers_controller.rb 94.74 %
/lib/benchmarking/benchmarker.rb 0.0 %

@apoorv1316 apoorv1316 merged commit d57398c into develop Jul 6, 2022
@apoorv1316 apoorv1316 deleted the time-entry-report-issue branch July 6, 2022 14:03
@pr-triage pr-triage bot added the PR: merged label Jul 6, 2022
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
@onkar-saeloun
Time Entry Report Bug (#548)
52c9c95 
* resolved issue

* rermoved spaces

* changed padding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apoorv1316 apoorv1316 apoorv1316 approved these changes

@harshaanNihal harshaanNihal Awaiting requested review from harshaanNihal

Assignees

@onkar-saeloun onkar-saeloun

Labels

bug Something isn't working PR: merged PR: partially-approved PR: unreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@onkar-saeloun @apoorv1316