Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bug/close add line item box on edit page#550

Merged
supriya3105 merged 1 commit intodevelopfrom
Bug/close_add_line_box_on_edit
Jul 7, 2022
Merged

Bug/close add line item box on edit page#550
supriya3105 merged 1 commit intodevelopfrom
Bug/close_add_line_box_on_edit

Conversation

@Shruti-Apte
Copy link
Contributor

@Shruti-Apte Shruti-Apte commented Jul 7, 2022

Notion card

https://www.notion.so/saeloun/The-add-line-item-box-is-not-closing-on-edit-invoice-page-96af1beddb8f40acae4612ff890e78b3

Summary

  • Admin/Owner can now close the add line item box on edit invoice

Preview

https://www.loom.com/share/b5794a2ecf92462c8181e9eadfb97ee3

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code

@github-actions
Copy link

github-actions bot commented Jul 7, 2022

Current Code Coverage Percent of this PR:

89.25 %

Files having coverage below 100%

Impacted Files Coverage
/lib/custom_failure.rb 80.0 %
/app/services/weekly_reminder_for_missed_entries_service.rb 31.82 %
/app/controllers/users/invitations_controller.rb 92.86 %
/app/controllers/users/sessions_controller.rb 85.71 %
/app/services/invoice_payment/checkout.rb 44.0 %
/app/services/invoice_payment/pdf_generation.rb 70.0 %
/app/controllers/internal_api/v1/payment_settings_controller.rb 93.33 %
/app/controllers/internal_api/v1/profile_controller.rb 96.88 %
/app/controllers/internal_api/v1/companies_controller.rb 95.45 %
/app/controllers/internal_api/v1/wise/recipients_controller.rb 90.0 %
/app/controllers/internal_api/v1/payments/providers_controller.rb 94.74 %
/lib/benchmarking/benchmarker.rb 0.0 %

@Shruti-Apte Shruti-Apte changed the title add new line box closing on edit page Bug/close add line item box on edit page Jul 7, 2022
@supriya3105 supriya3105 merged commit 6793dee into develop Jul 7, 2022
@supriya3105 supriya3105 deleted the Bug/close_add_line_box_on_edit branch July 7, 2022 07:22
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
@Shruti-Apte
Bug/close add line item box on edit page (#550)
ac0acec 
add new line box closing on edit page

Co-authored-by: Shruti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apoorv1316 apoorv1316 apoorv1316 approved these changes

@supriya3105 supriya3105 Awaiting requested review from supriya3105

Assignees

No one assigned

Labels

PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Shruti-Apte @apoorv1316 @supriya3105