Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix warning for find_by_id selector #1227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vipulnsward merged 2 commits into from
Apr 6, 2023
Merged

Fix warning for find_by_id selector #1227

vipulnsward merged 2 commits into from
Apr 6, 2023

Conversation

@apoorv1316
Copy link
Collaborator

@apoorv1316 apoorv1316 commented Apr 6, 2023

What

  • Used to_s method in the find_by_id selector to convert the id to string.

Why

  • Using integer for id will raise an error in a future version of Capybara

@vipulnsward vipulnsward merged commit 577638e into develop Apr 6, 2023
@vipulnsward vipulnsward deleted the fix-capybayara-id-warning branch April 6, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@prasanthchaduvula prasanthchaduvula

Labels

PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@apoorv1316 @vipulnsward @prasanthchaduvula