Merged
Conversation
merge with develop
merge with develop
Contributor
|
@Shruti-Apte Please add system specs |
Contributor
|
As discussed, Apoorv will work on fixing the failing system specs. |
Contributor
|
@Shruti-Apte Please fix the failing checks |
merge with develop
merge with develop
prasanthchaduvula
approved these changes
Jul 4, 2023
vipulnsward
pushed a commit
that referenced
this pull request
Feb 15, 2026
* add code to show and update employment * add request specs * add policy specs * fix policy * employment details design and integration * employment edit form validations * add code for bulk opertaions on previous employments * Bulk update previous employment details integrated * fetch personal details on layout index page * rubocop error fixed * draft system specs added * fill form values test * specs updated and error message added * date format error fixed * value not loading error fixed * company added to usercontext * specs fixed --------- Co-authored-by: “Apoorv <“[email protected]”> Co-authored-by: Apoorv Tiwari <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notion :
https://www.notion.so/saeloun/Combine-previous-employments-APIs-for-Employee-and-Admin-0e05f8024ea94d3a99c62ac6a18e2656?pvs=4
What :
Why :
Preview :
https://www.loom.com/share/dd0f713659bb4474a8be9605c56a5da4
Todos (for testing):
Tested CRUD operations for employment details