Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@mayankagnihotri7
Copy link
Contributor

Notion Card

Notion Card

Description

  • Send invoice payment reminders to clients.

@mayankagnihotri7 mayankagnihotri7 marked this pull request as draft July 5, 2023 13:19
@mayankagnihotri7 mayankagnihotri7 marked this pull request as ready for review July 13, 2023 13:05
@apoorv1316
Copy link
Collaborator

@mayankagnihotri7 Few fixes that are required
Screenshot 2023-07-14 at 5 07 26 PM
Screenshot 2023-07-14 at 5 12 18 PM

  1. As per the notion ticket, first the overdue invoices should be listed followed by viewed and then sent invoices.
  2. If 1 invoice is selected the text should be "1 invoice selected"
  3. If we click on view invoice on the "send payment reminder" modal it opens a new tab but takes us to the client's page instead of the invoice
  4. The email only lists one invoice but I had selected 3 invoices. Also, the CSS needs to be fixed. Check figma design

@mayankagnihotri7
Copy link
Contributor Author

@apoorv1316 I've made the requested changes. Please review.

@apoorv1316
Copy link
Collaborator

@mayankagnihotri7 Please fix

  • Modal should have the invoice sent at the date and due date. @supriya3105 In designs we have an issue date but in notion, it is invoice sent at. Does it mean the same?
  • By default, all overdue invoices should be selected. Currently, all invoices are selected.

@apoorv1316 apoorv1316 removed their assignment Jul 18, 2023
@mayankagnihotri7
Copy link
Contributor Author

@apoorv1316 I've made the requested change for only overdue invoices to be selected by default. Please review.

@prasanthchaduvula prasanthchaduvula merged commit 028dd7c into develop Jul 21, 2023
@prasanthchaduvula prasanthchaduvula deleted the send-due-invoice-payment-reminder branch July 21, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants