Holiday tables, models and controller#1451
Merged
prasanthchaduvula merged 15 commits intodevelopfrom Sep 27, 2023
Merged
Conversation
prasanthchaduvula
requested changes
Sep 8, 2023
Contributor
|
@apoorv1316 Add controller level and service test cases |
72b9629 to
8808a9b
Compare
Contributor
|
@apoorv1316 Please resolve conflicts |
prasanthchaduvula
approved these changes
Sep 27, 2023
vipulnsward
pushed a commit
that referenced
this pull request
Feb 15, 2026
* add holiday tables and models * Add company ref to holidays * Add create for holidays * index action for holidays * holiday operations service * add time_period for optional holidays * change enum types * add validation for name & year * add tests * refactored holidays controller, service and index jbuilder * Integrated the holidays api to add, update and remove holidays along with holidays infos * fixed holidays service specs --------- Co-authored-by: “Apoorv <“[email protected]”> Co-authored-by: Prasanth Chaduvula <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notion:
https://www.notion.so/saeloun/6afc9500b2cc42af86be55f37894fb09?v=b4528f26f4424af7beaf036262796cb3&p=2046f632b29c4be9b1d63ce66c935523&pm=s
What