Show payment entry modal on invoice page #1576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supriya3105
approved these changes
Nov 1, 2023
Contributor
supriya3105
left a comment
There was a problem hiding this comment.
Looks good .
There is a minor change required. The first field on the modal is displaying the client name whereas it should display the invoice number as well.
However that is an existing issue which we can fix in separate PR.
prasanthchaduvula
requested changes
Nov 1, 2023
app/javascript/src/components/Invoices/Invoice/InvoiceActions.tsx
Outdated
Show resolved
Hide resolved
app/javascript/src/components/Invoices/Invoice/MarkInvoicePaidModal.tsx
Outdated
Show resolved
Hide resolved
app/javascript/src/components/Invoices/Invoice/MarkInvoicePaidModal.tsx
Outdated
Show resolved
Hide resolved
prasanthchaduvula
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
Loom:
https://www.loom.com/share/45ca4e3552ad40f191fb9373379727d6