Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Close the edit members modal on saving the changes#324

Merged
supriya3105 merged 1 commit intodevelopfrom
close-edit-members-modal-on-save
Apr 25, 2022
Merged

Close the edit members modal on saving the changes#324
supriya3105 merged 1 commit intodevelopfrom
close-edit-members-modal-on-save

Conversation

@shalapatil
Copy link
Contributor

@shalapatil shalapatil commented Apr 25, 2022

Notion card

https://www.notion.so/saeloun/6afc9500b2cc42af86be55f37894fb09?v=185bd45b9dc24dfcad9c57c07d32a7c0&p=e3d3b736297742c18f06b5cac7d090e7

Summary

Saving the changes was not closing the modal. Fixed it.

Preview

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@github-actions
Copy link

Current Code Coverage Percent of this PR:

99.52 %

Files having coverage below 100%

Impacted Files Coverage
/app/controllers/invoices_controller.rb 63.64 %

@supriya3105 supriya3105 self-requested a review April 25, 2022 12:04
@supriya3105 supriya3105 merged commit e41a02c into develop Apr 25, 2022
@supriya3105 supriya3105 deleted the close-edit-members-modal-on-save branch April 25, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants