Codestin Search App

shivamsinghchahar · 2022-04-25T12:20:16Z

Fixes #304

https://www.loom.com/share/a91974fb521e4e29afa830c50bd219ad

github-actions · 2022-04-25T12:22:25Z

Current Code Coverage Percent of this PR:

96.71 %

Files having coverage below 100%

Impacted Files	Coverage
/app/controllers/invoices_controller.rb	63.64 %
/app/models/invoice.rb	95.83 %
/app/models/client.rb	92.31 %
/app/services/application_service.rb	66.67 %
/app/controllers/invoices/payments_controller.rb	61.11 %
/app/services/invoice_payment/checkout.rb	43.48 %

rohitjoshixyz

Provided some feedback

rohitjoshixyz · 2022-04-25T12:40:50Z

app/controllers/invoices/payments_controller.rb

+  private
+
+    def load_invoice
+      @invoice = Invoice.includes(client: :company).find(params[:invoice_id])


We can remove the load_invoice before action

Suggested change

@invoice = Invoice.includes(client: :company).find(params[:invoice_id])

def invoice

@_invoice ||= Invoice.includes(client: :company).find(params[:invoice_id])

end

We follow this convention in Miru for memorized variables. Global search for @_

Btw how will the view templates access this instance variable since we are not loading this in before_action?

Pass as locals

Just one last confusion, Why are we using instance variables if we want to pass them as locals? They should anyway be available to the views, right?

It feels like we are deliberately not taking advantage of the magic that Rails provides us.

Is there any specific reason we decided to move away from our own set standards in Miru?

I think because, in this action, we are using the variable only to pass as locals, but for a complex action we might use the invoice method at multiple places and so an instance variable will be accessible everywhere, for example a private method would not need an argument to be passed

rohitjoshixyz · 2022-04-25T12:46:58Z

app/services/application_service.rb

+# frozen_string_literal: true
+
+class ApplicationService
+  def self.process(*args, &block)


I prefer to name the method perform. Also @alkesh26 @keshavbiswa @akhilgkrishnan We were going to use an interactor pattern right? Or since this PR is urgent, we could go with service classes and then refactor later

Yes initially the plan was to add interactor classes rather than service classes, if the PR is urgent we can go with service classes too.

rohitjoshixyz · 2022-04-25T12:47:58Z

app/services/invoice_payment/checkout.rb

+  class Checkout < ApplicationService
+    def initialize(params)
+      @invoice = params[:invoice]
+      @company = invoice.client.company


Can we add an association, or delegation so we could access like invoice.company

rohitjoshixyz · 2022-04-25T12:48:50Z

app/services/invoice_payment/checkout.rb

+        ensure_client_registered!
+        checkout!


Just curious why are we using bang methods everywhere?

Since we are not rescuing the exceptions, I added ! to indicate that we should expect these methods to raise exceptions.

rohitjoshixyz · 2022-04-25T12:50:59Z

app/services/invoice_payment/checkout.rb

+      def description
+        "Invoice from #{company.name} for #{currency} #{invoice.amount} due on #{invoice.due_date}"
+      end


Let's consider adding an invoice_presenter cc @keshavbiswa @alkesh26

Presenters are needed in many places, maybe we can start with this PR.

rohitjoshixyz · 2022-04-25T12:53:46Z

db/migrate/20220425074402_add_stripe_id_to_clients.rb

+
+class AddStripeIdToClients < ActiveRecord::Migration[7.0]
+  def change
+    add_column :clients, :stripe_id, :string, default: nil


@supriya3105 Do we have only one stripe account per client?

This is to sync customers and payments on stripe.

rohitjoshixyz · 2022-04-25T12:57:58Z

spec/requests/invoices/payments_spec.rb

+require "rails_helper"
+
+RSpec.describe "Invoices::Payments", type: :request do
+  describe "GET /index" do
+    pending "add some examples (or delete) #{__FILE__}"
+  end
+end


Specs are pending, checkout https://github.com/stripe-ruby-mock/stripe-ruby-mock

Thanks! This is awesome🚀

rohitjoshixyz · 2022-04-25T13:01:06Z

app/views/invoice_mailer/invoice.text.erb

@@ -4,5 +4,7 @@ Hi, <%= @invoice.client_name %>
 You have an invoice - <%= @invoice.invoice_number %> with amount <%= @invoice.amount %>


Amount would be in cents, convert it to $

keshavbiswa

Left some comments.

keshavbiswa · 2022-04-26T03:38:55Z

app/controllers/invoices/payments_controller.rb

+  def success
+    @invoice.paid!
+  end
+
+  def cancel
+    render
+  end


We prefer REST based controllers.

supriya3105 · 2022-04-26T08:49:44Z

@apoorv1316 please test it and merge if all ok.

shivamsinghchahar self-assigned this Apr 25, 2022

pr-triage bot added the PR: unreviewed label Apr 25, 2022

Add stripe checkout for invoices

097a37f

shivamsinghchahar force-pushed the 304-enable-stripe-for-invoice-payments branch from ca8b162 to 097a37f Compare April 25, 2022 12:22

rohitjoshixyz reviewed Apr 25, 2022

View reviewed changes

keshavbiswa reviewed Apr 26, 2022

View reviewed changes

supriya3105 mentioned this pull request Apr 26, 2022

Feedback on Stripe Integration #334

Closed

vipulnsward merged commit 644dea8 into develop Apr 26, 2022

vipulnsward deleted the 304-enable-stripe-for-invoice-payments branch April 26, 2022 11:16

pr-triage bot added PR: merged and removed PR: unreviewed labels Apr 26, 2022

vipulnsward pushed a commit that referenced this pull request Feb 15, 2026

Add stripe checkout for invoices (#325)

bf5f067

-      @invoice = Invoice.includes(client: :company).find(params[:invoice_id])
+def invoice
+  @_invoice ||= Invoice.includes(client: :company).find(params[:invoice_id])
+end

		@@ -4,5 +4,7 @@ Hi, <%= @invoice.client_name %>
		You have an invoice - <%= @invoice.invoice_number %> with amount <%= @invoice.amount %>

Conversation

shivamsinghchahar commented Apr 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current Code Coverage Percent of this PR:

96.71 %

Files having coverage below 100%

Uh oh!

rohitjoshixyz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

keshavbiswa left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

supriya3105 commented Apr 26, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

shivamsinghchahar commented Apr 25, 2022 •

edited

Loading

github-actions bot commented Apr 25, 2022 •

edited

Loading