Conversation
Current Code Coverage Percent of this PR:99.28 %Files having coverage below 100%
|
apoorv1316
approved these changes
Apr 26, 2022
Collaborator
apoorv1316
left a comment
There was a problem hiding this comment.
@ajinkyaa Can you add a little bit of spacing between the add-ons description and the rate description? refer Figma design
shivamsinghchahar
suggested changes
Apr 26, 2022
Contributor
shivamsinghchahar
left a comment
There was a problem hiding this comment.
One small change, rest LGTM
config/routes.rb
Outdated
| get "payments", to: "payments#index" | ||
|
|
||
| get "subscriptions/*path", to: "subscriptions#index", via: :all | ||
| get "subscriptions", to: "subscriptions#index" |
Contributor
There was a problem hiding this comment.
use resourceful routes
Suggested change
| get "subscriptions", to: "subscriptions#index" | |
| resources :subscriptions, only: [:index] |
Contributor
Author
There was a problem hiding this comment.
Will that allow me to have react routes?
Contributor
|
@ajinkyaa Also, could you attach a loom video? |
Contributor
Author
subscription-design.mp4 |
shivamsinghchahar
approved these changes
Apr 27, 2022
vipulnsward
pushed a commit
that referenced
this pull request
Feb 15, 2026
* subscription page added * background color updated * comments resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
subscription page design.
https://www.figma.com/file/4gdPDRPqGqQqPYsO3Qj8CG/Miru-App?node-id=4849%3A48734
Checklist: