Adds ability to generate and send InvoicePDF as an attachment.#346
Merged
apoorv1316 merged 10 commits intodevelopfrom May 9, 2022
Merged
Adds ability to generate and send InvoicePDF as an attachment.#346apoorv1316 merged 10 commits intodevelopfrom
apoorv1316 merged 10 commits intodevelopfrom
Conversation
Collaborator
|
@anasansari157 CI check failed. |
fe932c0 to
36764b6
Compare
Current Code Coverage Percent of this PR:94.4 %Files having coverage below 100%
|
Member
akhilgkrishnan
left a comment
There was a problem hiding this comment.
@anasansari157 Added some suggestions, also Can you add test for helpers and mailers.
rohitjoshixyz
suggested changes
Apr 28, 2022
Contributor
rohitjoshixyz
left a comment
There was a problem hiding this comment.
Some refactoring needed
Collaborator
|
@mohd-anas-ansari Have you fixed all the review comments on this PR? |
Contributor
Author
|
@apoorv1316 Yes, all reviews have been addressed. |
rohitjoshixyz
approved these changes
May 4, 2022
Contributor
rohitjoshixyz
left a comment
There was a problem hiding this comment.
Some non-blocking comments, LGTM 🎉
shivamsinghchahar
suggested changes
May 4, 2022
- Fixes space between "Amount" and number.
df786ca to
16bf973
Compare
Contributor
|
@apoorv1316 Please test this . |
apoorv1316
approved these changes
May 6, 2022
Collaborator
|
@shivamsinghchahar Please approve it so it can be merged. |
vipulnsward
pushed a commit
that referenced
this pull request
Feb 15, 2026
* Adds ability to generate and send InvoicePDF as an attachment. * Fixes CI build error * Adds yarn * - Fixes typo - Fixes space between "Amount" and number. * Adds helpers for invoice. * Adds reply_to in mail. * Minimizes serializer queries. * Methods isolation. * Moves pdf_generation to services. * Shows quantity in hours.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notion card
https://www.notion.so/saeloun/Generate-PDF-attachment-of-the-invoice-21035ae1b67a4aa7820b1ae21d7290b6
Summary
Added generation of PDF AS attachment while mailing invoices.
Preview
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist: