Added Payments Setting tab in the settings #351
Merged
vipulnsward merged 2 commits intodevelopfrom Apr 28, 2022
Merged
Conversation
Current Code Coverage Percent of this PR:96.54 %Files having coverage below 100%
|
keshavbiswa
reviewed
Apr 28, 2022
Contributor
keshavbiswa
left a comment
There was a problem hiding this comment.
Added some comments.
| @@ -0,0 +1 @@ | |||
| <H1>Code</H1> No newline at end of file | |||
Contributor
There was a problem hiding this comment.
I'm not sure what this is supposed to be?
Contributor
Author
There was a problem hiding this comment.
This I kept for reference, Shruti will work on that page,
| @@ -0,0 +1,7 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| class PaymentsSettingController < ApplicationController | |||
Contributor
There was a problem hiding this comment.
Shouldn't this be PaymentSettings controller?
Contributor
Author
There was a problem hiding this comment.
I can change it to paymentSettings,
config/routes.rb
Outdated
Comment on lines
65
to
66
| get "payments_setting/*path", to: "payments_setting#index", via: :all | ||
| get "payments_setting", to: "payments_setting#index" |
Contributor
There was a problem hiding this comment.
I'm not understanding why are we doing this and not
resource :payment_settings, only: [:index]Is there a specific use case I'm missing?
Contributor
Author
There was a problem hiding this comment.
This is how Ajinkya prefers for react components
vipulnsward
pushed a commit
that referenced
this pull request
Feb 15, 2026
* added payments_setting * change payments_setting to payment_settings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notion card
Checklist: