Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixes unit_amount for zero_decimal_currencies#353

Merged
mohd-anas-ansari merged 4 commits intodevelopfrom
stripe-fix
May 5, 2022
Merged

Fixes unit_amount for zero_decimal_currencies#353
mohd-anas-ansari merged 4 commits intodevelopfrom
stripe-fix

Conversation

@mohd-anas-ansari
Copy link
Contributor

@mohd-anas-ansari mohd-anas-ansari commented Apr 30, 2022 •
edited
Loading

Notion card

Summary

Preview

Earlier:
Screenshot 2022-04-30 at 6 03 54 PM

After fix:
Screenshot 2022-04-30 at 6 03 20 PM

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@github-actions
Copy link

github-actions bot commented Apr 30, 2022 •
edited
Loading

Current Code Coverage Percent of this PR:

96.56 %

Files having coverage below 100%

Impacted Files Coverage
/app/controllers/subscriptions_controller.rb 66.67 %
/app/controllers/invoices_controller.rb 63.64 %
/app/models/client.rb 92.5 %
/app/models/invoice.rb 96.15 %
/app/policies/subscriptions_policy.rb 66.67 %
/app/services/application_service.rb 66.67 %
/app/controllers/invoices/payments_controller.rb 61.11 %
/app/services/invoice_payment/checkout.rb 43.48 %

@apoorv1316
Copy link
Collaborator

apoorv1316 commented May 4, 2022

@shivamsinghchahar Can you please review this?

rohitjoshixyz
rohitjoshixyz approved these changes May 4, 2022
View reviewed changes
Copy link
Contributor

@rohitjoshixyz rohitjoshixyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, add a service spec for both scenarios zero decimal and normal currency

rohitjoshixyz
rohitjoshixyz reviewed May 4, 2022
View reviewed changes
shivamsinghchahar
shivamsinghchahar suggested changes May 4, 2022
View reviewed changes
shivamsinghchahar
shivamsinghchahar approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@shivamsinghchahar shivamsinghchahar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🚀

@mohd-anas-ansari mohd-anas-ansari merged commit 41214c0 into develop May 5, 2022
@mohd-anas-ansari mohd-anas-ansari deleted the stripe-fix branch May 5, 2022 09:21
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
@mohd-anas-ansari
Merge pull request #353 from saeloun/stripe-fix
7211ec0 
Fixes unit_amount for zero_decimal_currencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akhilgkrishnan akhilgkrishnan Awaiting requested review from akhilgkrishnan

2 more reviewers

@rohitjoshixyz rohitjoshixyz rohitjoshixyz approved these changes

@shivamsinghchahar shivamsinghchahar shivamsinghchahar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mohd-anas-ansari @apoorv1316 @shivamsinghchahar @rohitjoshixyz