Perform actions project details page#358
Merged
apoorv1316 merged 5 commits intodevelopfrom May 5, 2022
Merged
Conversation
Contributor
|
@onkar-saeloun Please review this PR. |
apoorv1316
approved these changes
May 4, 2022
Collaborator
apoorv1316
left a comment
There was a problem hiding this comment.
LGTM from functional perspective.
| // Add error handling | ||
| }) | ||
| .catch(() => { | ||
| // Add error handling |
Collaborator
There was a problem hiding this comment.
@Shruti-Apte Can you wrap the async function in try-catch? Also why we are leaving the catch block empty?
onkar-saeloun
approved these changes
May 4, 2022
Contributor
|
LGTM after resolving Apoorv's comment |
Contributor
|
@Shruti-Apte Please resolve the comments on this PR first ? |
Current Code Coverage Percent of this PR:96.55 %Files having coverage below 100%
|
Shruti-Apte
added a commit
that referenced
this pull request
May 6, 2022
* Basic UI for stripe connect * Addition to basic UI * Use react router for invoice page (#333) * API for show invoice * Remove show route * Use react router for invoice page * Address review comments * Refactor and fix UI * Avoid n+1 issue and use partials * Fix rubocop failure * Omit hash value * Set init value as null * added titleize property to name for capitalizing (#354) * Invoice address spacing fixed (#355) * Invoice address spacing fixed * added commas Co-authored-by: Shruti <[email protected]> * Bump version to 0.1.9 * Heroku One Click deploy added (#357) * Fixes unit_amount for zero_decimal_currencies * Moves unit_amout method to invoice model using Money gem. * Adds test cases for unit_amount. * Fixes typo * Perform actions project details page (#358) * Some actions added * Some actions added * Prepopulating client name on generate invoice page * Resolved comments Co-authored-by: Shruti <[email protected]> * Basic UI for stripe connect * Addition to basic UI * Updated designs Co-authored-by: Shruti <[email protected]> Co-authored-by: Apoorv Mishra <[email protected]> Co-authored-by: Onkar Hasabe <[email protected]> Co-authored-by: Akhil G Krishnan <[email protected]> Co-authored-by: Anas Ansari <[email protected]>
vipulnsward
pushed a commit
that referenced
this pull request
Feb 15, 2026
* Some actions added * Some actions added * Prepopulating client name on generate invoice page * Resolved comments Co-authored-by: Shruti <[email protected]>
vipulnsward
pushed a commit
that referenced
this pull request
Feb 15, 2026
* Basic UI for stripe connect * Addition to basic UI * Use react router for invoice page (#333) * API for show invoice * Remove show route * Use react router for invoice page * Address review comments * Refactor and fix UI * Avoid n+1 issue and use partials * Fix rubocop failure * Omit hash value * Set init value as null * added titleize property to name for capitalizing (#354) * Invoice address spacing fixed (#355) * Invoice address spacing fixed * added commas Co-authored-by: Shruti <[email protected]> * Bump version to 0.1.9 * Heroku One Click deploy added (#357) * Fixes unit_amount for zero_decimal_currencies * Moves unit_amout method to invoice model using Money gem. * Adds test cases for unit_amount. * Fixes typo * Perform actions project details page (#358) * Some actions added * Some actions added * Prepopulating client name on generate invoice page * Resolved comments Co-authored-by: Shruti <[email protected]> * Basic UI for stripe connect * Addition to basic UI * Updated designs Co-authored-by: Shruti <[email protected]> Co-authored-by: Apoorv Mishra <[email protected]> Co-authored-by: Onkar Hasabe <[email protected]> Co-authored-by: Akhil G Krishnan <[email protected]> Co-authored-by: Anas Ansari <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notion card
https://www.notion.so/saeloun/Project-details-page-the-user-should-be-able-to-perform-actions-a1127e3af5c3468d986fc9e60b1c1a0a
Summary
The user can perform actions on project details page.
Preview
https://www.loom.com/share/7e508b689ed344208fff3de20b369d3d
Type of change
How Has This Been Tested?
Checklist: