Codestin Search App

abinashpa · 2022-05-06T09:17:21Z

Notion card

Summary

https://www.loom.com/share/6f20757600f5423dbe1b89e880f46a38

Preview

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to
not work as expected)
This change requires a documentation update

How Has This Been Tested?

Checklist:

I have manually tested all workflows
I have performed a self-review of my own code
I have added automated tests for my code

…ekly-time-tracking

fixed root page tests. renamed "invoice-tab" to "invoices-tab"

…ekly-time-tracking

supriya3105 · 2022-05-06T09:42:30Z

@abinashpa The CI Checks are failing for this .

github-actions · 2022-05-09T14:54:48Z

Current Code Coverage Percent of this PR:

95.12 %

Files having coverage below 100%

Impacted Files	Coverage
/app/controllers/subscriptions_controller.rb	66.67 %
/app/controllers/invoices_controller.rb	63.64 %
/app/models/client.rb	92.68 %
/app/models/invoice.rb	96.15 %
/app/policies/timezone_policy.rb	66.67 %
/app/policies/subscriptions_policy.rb	66.67 %
/app/services/application_service.rb	66.67 %
/app/controllers/invoices/payments_controller.rb	61.11 %
/app/services/invoice_payment/checkout.rb	43.48 %
/app/controllers/internal_api/v1/timezones_controller.rb	37.5 %
/lib/countries_info.rb	0.0 %

supriya3105 · 2022-05-09T15:08:59Z

@apoorv1316 Please test this @sudeeptarlekar Please review .

spec/models/client_spec.rb

supriya3105 · 2022-05-10T12:07:18Z

@abinashpa Lets work on the review comments on priority and close this PR.

sudeeptarlekar

LGTM

* Invoice settings added * updated default mailer with an env * Deleted project visible bug (#361) * checkbox icons added * checking if project exist * fixed typo * spec/models/timesheet_entry_spec.rb updated * initial commit * weekly component * ui refactored * removed update_project controller * removed update_project controller * code refactor * crashing issue fix * try catch added in exios request * code refactor * DatesInWeek.tsx component added * minor ui changes * multiple edit entry bug fixes * rubocop issue fixed * removed note validation from rspec * large client, project name UI fixed * invoice spec update on invoice.due_date * fix invoices datacy label typo fixed root page tests. renamed "invoice-tab" to "invoices-tab" * migration for note added * interchange save & cancel button in SelectProject.tsx * initial commit * calendar added * useEffect for dayInfo to entryList * Akash's changes added * html entity added * daily & monthly sync * total daily hours patch added * patch added * patch added * restored duration validation * fixed starting day in week * changed variable names in hhmm-parser.ts * auto resize textarea added * default values added * added functionality in org edit page * added functionality in org edit page * Owner or admin can add clients for a company (#126) * Owner or admin can add clients for a company * Avoid instance vars in views, pass local vars instead * Pass local vars to views and toggle new client view display based on validation errors * Fix UI and support country and timezone * Configure failure and success messages via locales * Show total hours logged for each client * Fix eslint err * Remove memoization for client * Keep autofocus only on name * Refactor client specs * Bifurcate validations and associations into different describe blocks * Camelize hash keys when sending to react component * Use locales for labels * Extract clients hash merge into a method and split long exp into multiple lines * Add placeholders for input fields, fix dialog header text and fix locales * DRY up the styling * Follow BEM style * Replace with correct class * Fix model spec * Follow BEM style * Set company_id with other params * Fix class names * Move toaster to bottom center with a close button * Fix robocop issues * Config modal width as per design * Fix FactoryBot for client * conflicts resolved * revert new changes * restored client controller * -5:00 default for crate org page * default scope added to Client and Project * added map in client spec * added map in client spec * rename variable result to results * replaced map with match_array * removed duplicate results * removed more duplicate results Co-authored-by: Mohini Dahiya <[email protected]> Co-authored-by: Apoorv Mishra <[email protected]> * Invoice settings added * resolved comments * disable cypress tests on ci (#374) Co-authored-by: “Apoorv <“[email protected]”> * Invoice settings added * resolved comments * Invoice settings added * resolved comments Co-authored-by: Shruti <[email protected]> Co-authored-by: Akhil G Krishnan <[email protected]> Co-authored-by: Abinash <[email protected]> Co-authored-by: Mohini Dahiya <[email protected]> Co-authored-by: Apoorv Mishra <[email protected]> Co-authored-by: Apoorv Tiwari <[email protected]> Co-authored-by: “Apoorv <“[email protected]”>

* checkbox icons added * checking if project exist * fixed typo * spec/models/timesheet_entry_spec.rb updated * initial commit * weekly component * ui refactored * removed update_project controller * removed update_project controller * code refactor * crashing issue fix * try catch added in exios request * code refactor * DatesInWeek.tsx component added * minor ui changes * multiple edit entry bug fixes * rubocop issue fixed * removed note validation from rspec * large client, project name UI fixed * invoice spec update on invoice.due_date * fix invoices datacy label typo fixed root page tests. renamed "invoice-tab" to "invoices-tab" * migration for note added * interchange save & cancel button in SelectProject.tsx * initial commit * calendar added * useEffect for dayInfo to entryList * Akash's changes added * html entity added * daily & monthly sync * total daily hours patch added * patch added * patch added * restored duration validation * fixed starting day in week * changed variable names in hhmm-parser.ts * auto resize textarea added * default values added * added functionality in org edit page * added functionality in org edit page * Owner or admin can add clients for a company (#126) * Owner or admin can add clients for a company * Avoid instance vars in views, pass local vars instead * Pass local vars to views and toggle new client view display based on validation errors * Fix UI and support country and timezone * Configure failure and success messages via locales * Show total hours logged for each client * Fix eslint err * Remove memoization for client * Keep autofocus only on name * Refactor client specs * Bifurcate validations and associations into different describe blocks * Camelize hash keys when sending to react component * Use locales for labels * Extract clients hash merge into a method and split long exp into multiple lines * Add placeholders for input fields, fix dialog header text and fix locales * DRY up the styling * Follow BEM style * Replace with correct class * Fix model spec * Follow BEM style * Set company_id with other params * Fix class names * Move toaster to bottom center with a close button * Fix robocop issues * Config modal width as per design * Fix FactoryBot for client * conflicts resolved * revert new changes * restored client controller * -5:00 default for crate org page * default scope added to Client and Project * added map in client spec * added map in client spec * rename variable result to results * replaced map with match_array * removed duplicate results * removed more duplicate results Co-authored-by: Mohini Dahiya <[email protected]> Co-authored-by: Apoorv Mishra <[email protected]>

* Invoice settings added * updated default mailer with an env * Deleted project visible bug (#361) * checkbox icons added * checking if project exist * fixed typo * spec/models/timesheet_entry_spec.rb updated * initial commit * weekly component * ui refactored * removed update_project controller * removed update_project controller * code refactor * crashing issue fix * try catch added in exios request * code refactor * DatesInWeek.tsx component added * minor ui changes * multiple edit entry bug fixes * rubocop issue fixed * removed note validation from rspec * large client, project name UI fixed * invoice spec update on invoice.due_date * fix invoices datacy label typo fixed root page tests. renamed "invoice-tab" to "invoices-tab" * migration for note added * interchange save & cancel button in SelectProject.tsx * initial commit * calendar added * useEffect for dayInfo to entryList * Akash's changes added * html entity added * daily & monthly sync * total daily hours patch added * patch added * patch added * restored duration validation * fixed starting day in week * changed variable names in hhmm-parser.ts * auto resize textarea added * default values added * added functionality in org edit page * added functionality in org edit page * Owner or admin can add clients for a company (#126) * Owner or admin can add clients for a company * Avoid instance vars in views, pass local vars instead * Pass local vars to views and toggle new client view display based on validation errors * Fix UI and support country and timezone * Configure failure and success messages via locales * Show total hours logged for each client * Fix eslint err * Remove memoization for client * Keep autofocus only on name * Refactor client specs * Bifurcate validations and associations into different describe blocks * Camelize hash keys when sending to react component * Use locales for labels * Extract clients hash merge into a method and split long exp into multiple lines * Add placeholders for input fields, fix dialog header text and fix locales * DRY up the styling * Follow BEM style * Replace with correct class * Fix model spec * Follow BEM style * Set company_id with other params * Fix class names * Move toaster to bottom center with a close button * Fix robocop issues * Config modal width as per design * Fix FactoryBot for client * conflicts resolved * revert new changes * restored client controller * -5:00 default for crate org page * default scope added to Client and Project * added map in client spec * added map in client spec * rename variable result to results * replaced map with match_array * removed duplicate results * removed more duplicate results Co-authored-by: Mohini Dahiya <[email protected]> Co-authored-by: Apoorv Mishra <[email protected]> * Invoice settings added * resolved comments * disable cypress tests on ci (#374) Co-authored-by: “Apoorv <“[email protected]”> * Invoice settings added * resolved comments * Invoice settings added * resolved comments Co-authored-by: Shruti <[email protected]> Co-authored-by: Akhil G Krishnan <[email protected]> Co-authored-by: Abinash <[email protected]> Co-authored-by: Mohini Dahiya <[email protected]> Co-authored-by: Apoorv Mishra <[email protected]> Co-authored-by: Apoorv Tiwari <[email protected]> Co-authored-by: “Apoorv <“[email protected]”>

Abinash Panda and others added 30 commits February 17, 2022 11:38

checkbox icons added

d731942

refectored

c27eca7

checking if project exist

11029c3

fixed typo

ab55ed6

spec/models/timesheet_entry_spec.rb updated

ee637bc

initial commit

47f4e19

weekly component

0c03eb7

repo initilized

93bf2cd

ui refactored

8b54847

weekly crud added

7bdaef4

conflicts resolved

daf0e77

removed update_project controller

f2a827b

Merge branch 'develop' of https://github.com/saeloun/miru-web into we…

cd99d9a

…ekly-time-tracking

removed update_project controller

774f610

code refactor

01baec2

crashing issue fix

58d4576

try catch added in exios request

e77c138

code refactor

182f2bf

DatesInWeek.tsx component added

6bf4dcf

minor ui changes

a8f778e

multiple edit entry bug fixes

22990bb

font size removed

7f8db33

routes conflicts fixed

d7a85c6

rubocop issue fixed

e42d3b1

removed note validation from rspec

aa58b21

large client, project name UI fixed

a8b88c0

invoice spec update on invoice.due_date

c16caa5

fix invoices datacy label typo

bd39980

fixed root page tests. renamed "invoice-tab" to "invoices-tab"

Merge branch 'develop' of https://github.com/saeloun/miru-web into we…

ffc676a

…ekly-time-tracking

navbar.js updated

ce777a7

abinashpa requested review from apoorv1316 and supriya3105 May 6, 2022 09:39

Abinash Panda added 3 commits May 9, 2022 19:49

added map in client spec

382d804

added map in client spec

b433b64

rename variable result to results

2204088

abinashpa added the bug Something isn't working label May 9, 2022

supriya3105 requested a review from sudeeptarlekar May 9, 2022 15:05

supriya3105 approved these changes May 9, 2022

View reviewed changes

pr-triage bot added the PR: partially-approved label May 9, 2022

apoorv1316 approved these changes May 10, 2022

View reviewed changes

sudeeptarlekar suggested changes May 10, 2022

View reviewed changes

spec/models/client_spec.rb Outdated Show resolved Hide resolved

spec/models/client_spec.rb Outdated Show resolved Hide resolved

pr-triage bot added the PR: reviewed-changes-requested label May 10, 2022

Abinash Panda added 3 commits May 10, 2022 17:37

replaced map with match_array

b616b87

removed duplicate results

936eded

removed more duplicate results

4f4cc1e

abinashpa requested a review from sudeeptarlekar May 10, 2022 15:21

sudeeptarlekar approved these changes May 10, 2022

View reviewed changes

pr-triage bot added the PR: reviewed-approved label May 10, 2022

supriya3105 merged commit 935dbb6 into develop May 10, 2022

supriya3105 deleted the deleted-project-visible-bug branch May 10, 2022 16:00

pr-triage bot added the PR: merged label May 10, 2022

abinashpa restored the deleted-project-visible-bug branch June 7, 2022 19:55

akhilgkrishnan deleted the deleted-project-visible-bug branch September 5, 2023 16:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deleted project visible bug#361

Deleted project visible bug#361
supriya3105 merged 71 commits intodevelopfrom
deleted-project-visible-bug

abinashpa commented May 6, 2022 •

edited

Loading

Uh oh!

supriya3105 commented May 6, 2022

Uh oh!

github-actions bot commented May 9, 2022

Uh oh!

supriya3105 commented May 9, 2022

Uh oh!

Uh oh!

Uh oh!

supriya3105 commented May 10, 2022

Uh oh!

sudeeptarlekar left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

abinashpa commented May 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Notion card

Summary

Preview

Type of change

How Has This Been Tested?

Checklist:

Uh oh!

supriya3105 commented May 6, 2022

Uh oh!

github-actions bot commented May 9, 2022

Current Code Coverage Percent of this PR:

95.12 %

Files having coverage below 100%

Uh oh!

supriya3105 commented May 9, 2022

Uh oh!

Uh oh!

Uh oh!

supriya3105 commented May 10, 2022

Uh oh!

sudeeptarlekar left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

abinashpa commented May 6, 2022 •

edited

Loading