Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Stripe connect integration#363

Merged
apoorv1316 merged 18 commits intodevelopfrom
stripe-connect
May 13, 2022
Merged

Stripe connect integration#363
apoorv1316 merged 18 commits intodevelopfrom
stripe-connect

Conversation

@apoorv-mishra
Copy link
Contributor

@apoorv-mishra apoorv-mishra commented May 6, 2022 •
edited
Loading

Notion card

https://saeloun.notion.site/Stripe-Connect-for-all-accounts-4fd1069594564038b6f2b39f0fcf0bd5

Summary

Integrate stripe connect with Miru

Preview

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@pr-triage pr-triage bot added the PR: draft label May 6, 2022
@github-actions
Copy link

github-actions bot commented May 9, 2022 •
edited
Loading

Current Code Coverage Percent of this PR:

93.5 %

Files having coverage below 100%

Impacted Files Coverage
/app/controllers/payment_settings_controller.rb 66.67 %
/app/controllers/subscriptions_controller.rb 66.67 %
/app/controllers/invoices_controller.rb 63.64 %
/app/models/client.rb 92.68 %
/app/models/invoice.rb 96.3 %
/app/policies/subscriptions_policy.rb 66.67 %
/app/policies/timezone_policy.rb 66.67 %
/app/policies/payment_settings_policy.rb 71.43 %
/app/controllers/invoices/payments_controller.rb 61.11 %
/app/services/invoice_payment/pdf_generation.rb 65.38 %
/app/services/invoice_payment/checkout.rb 43.48 %
/app/controllers/internal_api/v1/payment_settings_controller.rb 45.45 %
/app/controllers/internal_api/v1/timezones_controller.rb 37.5 %
/lib/countries_info.rb 0.0 %

@apoorv-mishra apoorv-mishra marked this pull request as ready for review May 12, 2022 08:23
@supriya3105 supriya3105 requested a review from apoorv1316 May 12, 2022 08:37
sudeeptarlekar
sudeeptarlekar approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@sudeeptarlekar sudeeptarlekar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

rohitjoshixyz
rohitjoshixyz approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@rohitjoshixyz rohitjoshixyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

apoorv1316
apoorv1316 approved these changes May 13, 2022
View reviewed changes
Copy link
Collaborator

@apoorv1316 apoorv1316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀

@apoorv1316 apoorv1316 merged commit e9a224d into develop May 13, 2022
@apoorv1316 apoorv1316 deleted the stripe-connect branch May 13, 2022 12:11
@apoorv-mishra apoorv-mishra mentioned this pull request May 13, 2022
Merged
7 tasks
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
Stripe connect integration (#363)
c323fe5 
* Add route, controller action and model associated with stripe connect

* Add account_id col and corresponding index

* Config routes and actions for stripe connect

* Integrate stripe connect with FE

* Fix specs

* Add unique index for company_id

* Refactor and handle intermediate states

* Integrate with FE and handle different states

* Add refresh_url for stripe connect

* Use jbuilder for resp json

* Modify FE as json attr is modified

* Replace hardcoded urls with url helper methods

* Fix rubocop

* Redundant code

* Add specs for model validations and associations

* Add specs for model methods

* Fix specs

* Fix payment settings refs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apoorv1316 apoorv1316 apoorv1316 approved these changes

+2 more reviewers

@sudeeptarlekar sudeeptarlekar sudeeptarlekar approved these changes

@rohitjoshixyz rohitjoshixyz rohitjoshixyz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@apoorv-mishra @apoorv1316 @sudeeptarlekar @rohitjoshixyz