Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Reports filter addition#364

Merged
apoorv1316 merged 5 commits intodevelopfrom
reports-filter-addition
May 9, 2022
Merged

Reports filter addition#364
apoorv1316 merged 5 commits intodevelopfrom
reports-filter-addition

Conversation

@ajinkyaa
Copy link
Contributor

@ajinkyaa ajinkyaa commented May 8, 2022

Report Page Filter design

Screenshot 2022-05-08 at 7 02 59 PM

@supriya3105
Copy link
Contributor

@ajinkyaa The CI checks are failing for this PR. Please fix them. Also, @apoorv1316 please test this with Ajinkya and verify the filter and group by options.

@github-actions
Copy link

github-actions bot commented May 9, 2022

Current Code Coverage Percent of this PR:

95.11 %

Files having coverage below 100%

Impacted Files Coverage
/app/controllers/subscriptions_controller.rb 66.67 %
/app/controllers/invoices_controller.rb 63.64 %
/app/models/client.rb 92.5 %
/app/models/invoice.rb 96.15 %
/app/policies/timezone_policy.rb 66.67 %
/app/policies/subscriptions_policy.rb 66.67 %
/app/services/application_service.rb 66.67 %
/app/controllers/invoices/payments_controller.rb 61.11 %
/app/services/invoice_payment/checkout.rb 43.48 %
/app/controllers/internal_api/v1/timezones_controller.rb 37.5 %
/lib/countries_info.rb 0.0 %

@supriya3105
Copy link
Contributor

@apoorv1316 Please test this on priority

@apoorv1316 apoorv1316 merged commit 677f462 into develop May 9, 2022
@apoorv1316 apoorv1316 deleted the reports-filter-addition branch May 9, 2022 11:53
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
* report page updated

* lint fixes

* aligment fixed

* spec fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants