Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixed filename#371

Merged
supriya3105 merged 2 commits intodevelopfrom
fix-filename
May 12, 2022
Merged

Fixed filename#371
supriya3105 merged 2 commits intodevelopfrom
fix-filename

Conversation

@sudeeptarlekar
Copy link
Contributor

@sudeeptarlekar sudeeptarlekar commented May 11, 2022

Signed-off-by: sudeeptarlekar [email protected]

Notion card

NA

Summary

Fixed Filename for common component

Type of change

Code Enhancement

@sudeeptarlekar
Fixed filename
426db8d 
Signed-off-by: sudeeptarlekar <[email protected]>
@sudeeptarlekar sudeeptarlekar requested a review from ajinkyaa May 11, 2022 03:03
@github-actions
Copy link

github-actions bot commented May 11, 2022 •
edited
Loading

Current Code Coverage Percent of this PR:

94.42 %

Files having coverage below 100%

Impacted Files Coverage
/app/controllers/subscriptions_controller.rb 66.67 %
/app/controllers/invoices_controller.rb 63.64 %
/app/models/client.rb 92.68 %
/app/models/invoice.rb 96.3 %
/app/policies/subscriptions_policy.rb 66.67 %
/app/policies/timezone_policy.rb 66.67 %
/app/controllers/invoices/payments_controller.rb 61.11 %
/app/services/invoice_payment/pdf_generation.rb 65.38 %
/app/services/invoice_payment/checkout.rb 43.48 %
/app/controllers/internal_api/v1/timezones_controller.rb 37.5 %
/lib/countries_info.rb 0.0 %

@apoorv1316
Copy link
Collaborator

apoorv1316 commented May 12, 2022

@sudeeptarlekar Can you please take the latest changes from develop and re-run the job again?

akhilgkrishnan
akhilgkrishnan approved these changes May 12, 2022
View reviewed changes
Copy link
Member

@akhilgkrishnan akhilgkrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@supriya3105 supriya3105 merged commit 38eff2d into develop May 12, 2022
@supriya3105 supriya3105 deleted the fix-filename branch May 12, 2022 08:07
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
@sudeeptarlekar @akhilgkrishnan
Fixed filename (#371)
822ce7e 
Signed-off-by: sudeeptarlekar <[email protected]>

Co-authored-by: Akhil G Krishnan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akhilgkrishnan akhilgkrishnan akhilgkrishnan approved these changes

@ajinkyaa ajinkyaa Awaiting requested review from ajinkyaa

Assignees

No one assigned

Labels

PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sudeeptarlekar @apoorv1316 @akhilgkrishnan @supriya3105