Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Overdue outstanding integration#372

Merged
supriya3105 merged 8 commits intodevelopfrom
overdue-outstanding-integration
May 12, 2022
Merged

Overdue outstanding integration#372
supriya3105 merged 8 commits intodevelopfrom
overdue-outstanding-integration

Conversation

@onkar-saeloun
Copy link
Contributor

@onkar-saeloun onkar-saeloun commented May 11, 2022

Notion card

https://www.notion.so/saeloun/Frontend-Integration-Overdue-and-outstanding-amount-in-client-page-19a7ae6fef9a4bdf85865cee6b387a81

Summary

  • Added overdue and outstanding amount integration with backend API.
  • Added helper functions which will give output of numbers in number + words

Preview

MiruWeb.-.11.May.2022.mp4

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code

@onkar-saeloun onkar-saeloun added enhancement New feature or request feature labels May 11, 2022
@onkar-saeloun onkar-saeloun self-assigned this May 11, 2022
@onkar-saeloun onkar-saeloun requested a review from apoorv1316 May 11, 2022 07:09
@onkar-saeloun onkar-saeloun removed the enhancement New feature or request label May 11, 2022
@apoorv1316
Copy link
Collaborator

apoorv1316 commented May 11, 2022

@onkar-saeloun Please fix lint failing issues.

@github-actions
Copy link

github-actions bot commented May 11, 2022

Current Code Coverage Percent of this PR:

94.42 %

Files having coverage below 100%

Impacted Files Coverage
/app/controllers/subscriptions_controller.rb 66.67 %
/app/controllers/invoices_controller.rb 63.64 %
/app/models/client.rb 92.68 %
/app/models/invoice.rb 96.3 %
/app/policies/subscriptions_policy.rb 66.67 %
/app/policies/timezone_policy.rb 66.67 %
/app/controllers/invoices/payments_controller.rb 61.11 %
/app/services/invoice_payment/pdf_generation.rb 65.38 %
/app/services/invoice_payment/checkout.rb 43.48 %
/app/controllers/internal_api/v1/timezones_controller.rb 37.5 %
/lib/countries_info.rb 0.0 %

@apoorv1316
Copy link
Collaborator

apoorv1316 commented May 12, 2022

@onkar-saeloun Can you please take the latest changes from develop and re-run the job again?

@onkar-saeloun
Merge branch 'develop' of github.com:saeloun/miru-web into overdue-ou…
59c8b2e 
…tstanding-integration

merging develop branch
@supriya3105 supriya3105 requested a review from apoorv-mishra May 12, 2022 08:41
@supriya3105 supriya3105 merged commit d4b5232 into develop May 12, 2022
@supriya3105 supriya3105 deleted the overdue-outstanding-integration branch May 12, 2022 15:45
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
@onkar-saeloun
Overdue outstanding integration (#372)
80d77ad 
* added overdue and outstanding amt changes

* added overdue and outstanding amt changes

* added integration data

* added helper for cash formatter

* added helper for currency symbol

* resolved lintel errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apoorv1316 apoorv1316 apoorv1316 approved these changes

@akhilgkrishnan akhilgkrishnan Awaiting requested review from akhilgkrishnan

@apoorv-mishra apoorv-mishra Awaiting requested review from apoorv-mishra

Assignees

@onkar-saeloun onkar-saeloun

Labels

feature PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@onkar-saeloun @apoorv1316 @supriya3105