Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Sort timeline entries#377

Merged
supriya3105 merged 3 commits intodevelopfrom
sort-timeline-entries
May 20, 2022
Merged

Sort timeline entries#377
supriya3105 merged 3 commits intodevelopfrom
sort-timeline-entries

Conversation

@ajinkyaa
Copy link
Contributor

@github-actions
Copy link

github-actions bot commented May 12, 2022

Current Code Coverage Percent of this PR:

93.5 %

Files having coverage below 100%

Impacted Files Coverage
/app/controllers/payment_settings_controller.rb 66.67 %
/app/controllers/subscriptions_controller.rb 66.67 %
/app/controllers/invoices_controller.rb 63.64 %
/app/models/client.rb 92.68 %
/app/models/invoice.rb 96.3 %
/app/policies/subscriptions_policy.rb 66.67 %
/app/policies/timezone_policy.rb 66.67 %
/app/policies/payment_settings_policy.rb 71.43 %
/app/controllers/invoices/payments_controller.rb 61.11 %
/app/services/invoice_payment/pdf_generation.rb 65.38 %
/app/services/invoice_payment/checkout.rb 43.48 %
/app/controllers/internal_api/v1/payment_settings_controller.rb 45.45 %
/app/controllers/internal_api/v1/timezones_controller.rb 37.5 %
/lib/countries_info.rb 0.0 %

@ajinkyaa ajinkyaa requested a review from JijoBose May 13, 2022 04:12
Copy link
Contributor

@JijoBose JijoBose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase the PR before merging

@supriya3105
Copy link
Contributor

@apoorv1316 Please test this.

@supriya3105
Copy link
Contributor

@aniket-k-kaushik Please coordinate with Ajinkya on this PR. He has said that this will require work from back-end as well.

@supriya3105 supriya3105 merged commit 6d72447 into develop May 20, 2022
@supriya3105 supriya3105 deleted the sort-timeline-entries branch May 20, 2022 07:15
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
* timeline entries sort added

* lint fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants