Codestin Search App

sudeeptarlekar · 2022-05-16T13:11:17Z

Notion card

https://www.notion.so/saeloun/Edit-Invoice-05b8cca4cf234559a51c3d49f7c39573

Summary

Added Edit invoice page

Preview

Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Test cases for APIs were already in place.

Checklist:

I have manually tested all workflows
I have performed a self-review of my own code
I have added automated tests for my code

github-actions · 2022-05-17T07:16:03Z

Current Code Coverage Percent of this PR:

83.23 %

Files having coverage below 100%

Impacted Files	Coverage
/app/controllers/subscriptions_controller.rb	66.67 %
/app/controllers/invoices_controller.rb	57.14 %
/app/models/invoice.rb	96.3 %
/app/models/client.rb	92.68 %
/app/policies/timezone_policy.rb	66.67 %
/app/policies/subscriptions_policy.rb	66.67 %
/app/policies/client_policy.rb	95.45 %
/app/policies/invoice_policy.rb	94.12 %
/app/controllers/invoices/payments_controller.rb	61.11 %
/app/services/report/filters.rb	87.88 %
/app/services/invoice_payment/checkout.rb	43.48 %
/app/services/invoice_payment/pdf_generation.rb	66.67 %
/app/controllers/internal_api/v1/timezones_controller.rb	37.5 %
/app/controllers/internal_api/v1/clients_controller.rb	94.44 %
/app/controllers/internal_api/v1/invoices_controller.rb	94.87 %
/lib/benchmarking/benchmarker.rb	0.0 %
/lib/countries_info.rb	0.0 %

supriya3105 · 2022-05-17T10:32:28Z

@apoorv1316 Please test this PR.

apoorv1316

@sudeeptarlekar Few concerns

The amount is showing wrong after clicking on the edit invoice button. You can see in the video the amount was 5000 but it's showing 10,000.
Even after changing the due date of an invoice it's showing I guess the default due date on the invoice edit page. Also, I was not able to change the due date on the edit invoice.
https://www.loom.com/share/41e0d39a7a604c3db0054940ebd8a747

sudeeptarlekar · 2022-05-19T11:13:23Z

@apoorv1316 Fixed bugs, let me know if I am missing something.

app/views/internal_api/v1/invoices/edit.json.jbuilder

apoorv-mishra

LGTM after resolving conflicts.

supriya3105 · 2022-05-23T09:14:03Z

@sudeeptarlekar Please resolve the conflicts on this PR.

apoorv1316 · 2022-05-23T09:50:43Z

@sudeeptarlekar This still has bugs on editing discount. Please see the loom video https://www.loom.com/share/006958646bdf4a6eb3e1e980baadd316

Signed-off-by: sudeeptarlekar <[email protected]>

* Added routes for invoice edit Signed-off-by: sudeeptarlekar <[email protected]> * Added Edit invoice components Signed-off-by: sudeeptarlekar <[email protected]> * Added invoice total component Signed-off-by: sudeeptarlekar <[email protected]> * Added edit invoice components Signed-off-by: sudeeptarlekar <[email protected]> * Added invoice Total component Signed-off-by: sudeeptarlekar <[email protected]> * Added update invoice api call in react app Signed-off-by: sudeeptarlekar <[email protected]> * Added invoice line items in edit invoice page Signed-off-by: sudeeptarlekar <[email protected]> * Corrected subtotal calculation Signed-off-by: sudeeptarlekar <[email protected]> * Removed Rubocop error Signed-off-by: sudeeptarlekar <[email protected]> * Removed ESLint errors Signed-off-by: sudeeptarlekar <[email protected]> * Corrected discount input Signed-off-by: sudeeptarlekar <[email protected]> * Removed blank file Signed-off-by: sudeeptarlekar <[email protected]> * Fixed amount bug Signed-off-by: sudeeptarlekar <[email protected]> * Fixed invoice discount and tax issue Signed-off-by: sudeeptarlekar <[email protected]> * Fixed discount bug Signed-off-by: sudeeptarlekar <[email protected]>

pr-triage bot added the PR: draft label May 16, 2022

sudeeptarlekar requested review from ajinkyaa, apoorv-mishra and supriya3105 and removed request for ajinkyaa May 17, 2022 09:01

sudeeptarlekar marked this pull request as ready for review May 17, 2022 09:01

pr-triage bot added PR: unreviewed and removed PR: draft labels May 17, 2022

supriya3105 requested a review from apoorv1316 May 17, 2022 10:32

apoorv1316 requested changes May 19, 2022

View reviewed changes

pr-triage bot added PR: reviewed-changes-requested PR: unreviewed and removed PR: unreviewed PR: reviewed-changes-requested labels May 19, 2022

sudeeptarlekar force-pushed the edit-invoice branch from 8862d9b to 6f52d83 Compare May 19, 2022 11:11

sudeeptarlekar requested a review from apoorv1316 May 19, 2022 11:13

supriya3105 removed their request for review May 20, 2022 07:04

apoorv-mishra reviewed May 20, 2022

View reviewed changes

app/views/internal_api/v1/invoices/edit.json.jbuilder Show resolved Hide resolved

apoorv-mishra reviewed May 20, 2022

View reviewed changes

app/views/internal_api/v1/invoices/edit.json.jbuilder Show resolved Hide resolved

apoorv-mishra reviewed May 20, 2022

View reviewed changes

app/views/internal_api/v1/invoices/edit.json.jbuilder Show resolved Hide resolved

apoorv-mishra reviewed May 20, 2022

View reviewed changes

app/views/internal_api/v1/invoices/edit.json.jbuilder Show resolved Hide resolved

apoorv-mishra approved these changes May 20, 2022

View reviewed changes

pr-triage bot added PR: partially-approved and removed PR: unreviewed labels May 20, 2022

sudeeptarlekar force-pushed the edit-invoice branch from 6f52d83 to 205444c Compare May 23, 2022 05:06

pr-triage bot removed the PR: partially-approved label May 23, 2022

pr-triage bot added the PR: unreviewed label May 23, 2022

sudeeptarlekar added 14 commits May 23, 2022 17:34

Added routes for invoice edit

e53d935

Signed-off-by: sudeeptarlekar <[email protected]>

Added Edit invoice components

bb5e738

Signed-off-by: sudeeptarlekar <[email protected]>

Added invoice total component

e4f52fa

Signed-off-by: sudeeptarlekar <[email protected]>

Added edit invoice components

1ba7ad3

Signed-off-by: sudeeptarlekar <[email protected]>

Added invoice Total component

99ba74a

Signed-off-by: sudeeptarlekar <[email protected]>

Added update invoice api call in react app

8745fdf

Signed-off-by: sudeeptarlekar <[email protected]>

Added invoice line items in edit invoice page

da56709

Signed-off-by: sudeeptarlekar <[email protected]>

Corrected subtotal calculation

856257f

Signed-off-by: sudeeptarlekar <[email protected]>

Removed Rubocop error

26a3b8a

Signed-off-by: sudeeptarlekar <[email protected]>

Removed ESLint errors

4308b2e

Signed-off-by: sudeeptarlekar <[email protected]>

Corrected discount input

b612a3a

Signed-off-by: sudeeptarlekar <[email protected]>

Removed blank file

88f0886

Signed-off-by: sudeeptarlekar <[email protected]>

Fixed amount bug

1fdd670

Signed-off-by: sudeeptarlekar <[email protected]>

Fixed invoice discount and tax issue

2f89699

Signed-off-by: sudeeptarlekar <[email protected]>

sudeeptarlekar force-pushed the edit-invoice branch from b423df0 to 2f89699 Compare May 23, 2022 12:06

Fixed discount bug

e43b2df

Signed-off-by: sudeeptarlekar <[email protected]>

vipulnsward merged commit ce49a09 into develop May 23, 2022

vipulnsward deleted the edit-invoice branch May 23, 2022 17:37

pr-triage bot added PR: merged and removed PR: unreviewed labels May 23, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Edit invoice#381

Edit invoice#381
vipulnsward merged 15 commits intodevelopfrom
edit-invoice

sudeeptarlekar commented May 16, 2022 •

edited

Loading

Uh oh!

github-actions bot commented May 17, 2022 •

edited

Loading

Uh oh!

supriya3105 commented May 17, 2022

Uh oh!

apoorv1316 left a comment •

edited

Loading

Uh oh!

sudeeptarlekar commented May 19, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

apoorv-mishra left a comment

Uh oh!

supriya3105 commented May 23, 2022

Uh oh!

apoorv1316 commented May 23, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

sudeeptarlekar commented May 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Notion card

Summary

Preview

Type of change

How Has This Been Tested?

Checklist:

Uh oh!

github-actions bot commented May 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current Code Coverage Percent of this PR:

83.23 %

Files having coverage below 100%

Uh oh!

supriya3105 commented May 17, 2022

Uh oh!

apoorv1316 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sudeeptarlekar commented May 19, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

apoorv-mishra left a comment

Choose a reason for hiding this comment

Uh oh!

supriya3105 commented May 23, 2022

Uh oh!

apoorv1316 commented May 23, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sudeeptarlekar commented May 16, 2022 •

edited

Loading

github-actions bot commented May 17, 2022 •

edited

Loading

apoorv1316 left a comment •

edited

Loading