Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Toaster redesign#382

Merged
gowsik-ragunath merged 4 commits intodevelopfrom
toaster-redesign
May 18, 2022
Merged

Toaster redesign#382
gowsik-ragunath merged 4 commits intodevelopfrom
toaster-redesign

Conversation

@gowsik-ragunath
Copy link
Contributor

@gowsik-ragunath gowsik-ragunath commented May 17, 2022 •
edited
Loading

Notion card

https://www.notion.so/saeloun/The-toast-message-on-time-tracking-module-is-displayed-for-a-long-time-and-needs-to-change-the-colou-e28b5a4a3223402283125b6b66723a40

Summary

Redesigned toaster message

Preview

https://www.loom.com/share/2e128070f8a24f1484d9a33e47d87caf

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@supriya3105 supriya3105 requested a review from apoorv1316 May 17, 2022 10:33
@supriya3105
Copy link
Contributor

supriya3105 commented May 17, 2022

@apoorv1316 please test this

AkashKale
AkashKale reviewed May 17, 2022
View reviewed changes
Copy link

@AkashKale AkashKale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep the duration for 4 seconds? In the loom video it seems to disappear very fast, even before we are able to read the complete message.

@github-actions
Copy link

github-actions bot commented May 17, 2022

Current Code Coverage Percent of this PR:

94.61 %

Files having coverage below 100%

Impacted Files Coverage
/app/controllers/subscriptions_controller.rb 66.67 %
/app/controllers/invoices_controller.rb 63.64 %
/app/models/client.rb 92.68 %
/app/models/invoice.rb 96.3 %
/app/policies/subscriptions_policy.rb 66.67 %
/app/policies/timezone_policy.rb 66.67 %
/app/controllers/invoices/payments_controller.rb 61.11 %
/app/services/invoice_payment/pdf_generation.rb 65.38 %
/app/services/invoice_payment/checkout.rb 43.48 %
/app/controllers/internal_api/v1/timezones_controller.rb 37.5 %
/lib/countries_info.rb 0.0 %

@gowsik-ragunath
Copy link
Contributor Author

gowsik-ragunath commented May 17, 2022

@AkashKale Previously, I've set the toaster to auto close within 3ms instead of 3000ms(3 seconds) which caused the toaster to disappear immediately.

I have changed the auto close duration, now the toaster will be displayed for 3 seconds.

akhilgkrishnan
akhilgkrishnan reviewed May 17, 2022
View reviewed changes
Copy link
Member

@akhilgkrishnan akhilgkrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gowsik-ragunath Overall LGTM. But one suggestion can you move all the images to the assets/images folder, And fetch those images in the react component

@gowsik-ragunath
Copy link
Contributor Author

gowsik-ragunath commented May 18, 2022

@akhilgkrishnan Moved the SVGs in the public folder to assets/images folder.

akhilgkrishnan
akhilgkrishnan approved these changes May 18, 2022
View reviewed changes
Copy link
Member

@akhilgkrishnan akhilgkrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@supriya3105
Copy link
Contributor

supriya3105 commented May 18, 2022

@AkashKale is this PR approved from your end ?

@AkashKale
Copy link

AkashKale commented May 18, 2022

@AkashKale is this PR approved from your end ?

Yes

@gowsik-ragunath gowsik-ragunath merged commit ec76930 into develop May 18, 2022
@gowsik-ragunath gowsik-ragunath deleted the toaster-redesign branch May 18, 2022 08:27
@pr-triage pr-triage bot added the PR: merged label May 18, 2022
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
@gowsik-ragunath
Toaster redesign (#382)
fe53f0b 
* Redesigned toaster notification

* Changed the toaster duration from 3ms to 3000ms

* Moved the svg icons in public to assets/image path

Co-authored-by: Gowsik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apoorv1316 apoorv1316 apoorv1316 approved these changes

@akhilgkrishnan akhilgkrishnan akhilgkrishnan approved these changes

@ajinkyaa ajinkyaa Awaiting requested review from ajinkyaa

+2 more reviewers

@AkashKale AkashKale AkashKale left review comments

@supriya3105 supriya3105 supriya3105 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gowsik-ragunath @supriya3105 @AkashKale @apoorv1316 @akhilgkrishnan