Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Employee dropdown#383

Merged
supriya3105 merged 10 commits intodevelopfrom
employee-dropdown
May 24, 2022
Merged

Employee dropdown#383
supriya3105 merged 10 commits intodevelopfrom
employee-dropdown

Conversation

@abinashpa
Copy link
Contributor

@abinashpa abinashpa commented May 17, 2022 •
edited
Loading

Notion card

Summary

Preview

https://www.loom.com/share/64f3149c1e1a4526a07a89c5faa22259

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@github-actions
Copy link

github-actions bot commented May 17, 2022 •
edited
Loading

Current Code Coverage Percent of this PR:

94.63 %

Files having coverage below 100%

Impacted Files Coverage
/app/controllers/subscriptions_controller.rb 66.67 %
/app/controllers/invoices_controller.rb 63.64 %
/app/models/invoice.rb 96.3 %
/app/models/client.rb 92.68 %
/app/policies/timezone_policy.rb 66.67 %
/app/policies/subscriptions_policy.rb 66.67 %
/app/controllers/invoices/payments_controller.rb 61.11 %
/app/services/invoice_payment/checkout.rb 43.48 %
/app/services/invoice_payment/pdf_generation.rb 65.38 %
/app/controllers/internal_api/v1/timezones_controller.rb 37.5 %
/lib/countries_info.rb 0.0 %

rohitjoshixyz
rohitjoshixyz reviewed May 18, 2022
View reviewed changes
Copy link
Contributor

@rohitjoshixyz rohitjoshixyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few suggestions

@supriya3105
Copy link
Contributor

supriya3105 commented May 18, 2022

@abinashpa Please check review comments from Rohit

@abinashpa
Copy link
Contributor Author

abinashpa commented May 19, 2022

@apoorv1316 Added the fixes for the issue (not fetching other employees' entries). Can you verify it?

@apoorv1316
Copy link
Collaborator

apoorv1316 commented May 19, 2022

@abinashpa Can you please look into this bug? https://www.loom.com/share/2245f4789a5e44ac80eef6e3998fd0e9

rohitjoshixyz
rohitjoshixyz approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@rohitjoshixyz rohitjoshixyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@supriya3105 supriya3105 merged commit 585d5eb into develop May 24, 2022
@supriya3105 supriya3105 deleted the employee-dropdown branch May 24, 2022 09:02
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
@akhilgkrishnan
Employee dropdown (#383)
6cd12d3 
* Create MIT License

* client index spec, match_array added

* employee dropdown added

* replace current_workplace with current_company in time_tracking_controller.rb

* fetch entries issue fixes

* admin's crud operation added

* useEffect for selectedEmployeeId added

* timesheet entry rspec fixes

Co-authored-by: Akhil G Krishnan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apoorv1316 apoorv1316 apoorv1316 approved these changes

@sudeeptarlekar sudeeptarlekar Awaiting requested review from sudeeptarlekar

+1 more reviewer

@rohitjoshixyz rohitjoshixyz rohitjoshixyz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feature frontend PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@abinashpa @supriya3105 @apoorv1316 @rohitjoshixyz @akhilgkrishnan