Thanks to visit codestin.com
Credit goes to github.com

Skip to content

client search enhancements#387

Merged
ajinkyaa merged 5 commits intodevelopfrom
client-search-enhancement
May 19, 2022
Merged

client search enhancements#387
ajinkyaa merged 5 commits intodevelopfrom
client-search-enhancement

Conversation

@ajinkyaa
Copy link
Contributor

@ajinkyaa ajinkyaa commented May 18, 2022

development screenshot:
Screenshot 2022-05-18 at 2 31 01 PM

figma:
https://www.figma.com/file/4gdPDRPqGqQqPYsO3Qj8CG/Miru-App?node-id=1839%3A32953

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@ajinkyaa ajinkyaa requested review from JijoBose and apoorv1316 May 18, 2022 09:02
@github-actions
Copy link

github-actions bot commented May 18, 2022 •
edited
Loading

Current Code Coverage Percent of this PR:

94.44 %

Files having coverage below 100%

Impacted Files Coverage
/app/controllers/subscriptions_controller.rb 66.67 %
/app/controllers/invoices_controller.rb 63.64 %
/app/models/invoice.rb 96.3 %
/app/models/client.rb 92.68 %
/app/policies/timezone_policy.rb 66.67 %
/app/policies/subscriptions_policy.rb 66.67 %
/app/controllers/invoices/payments_controller.rb 61.11 %
/app/services/report/filters.rb 87.88 %
/app/services/invoice_payment/checkout.rb 43.48 %
/app/services/invoice_payment/pdf_generation.rb 65.38 %
/app/controllers/internal_api/v1/timezones_controller.rb 37.5 %
/lib/countries_info.rb 0.0 %

JijoBose
JijoBose reviewed May 18, 2022
View reviewed changes
JijoBose
JijoBose reviewed May 18, 2022
View reviewed changes
JijoBose
JijoBose requested changes May 18, 2022
View reviewed changes
Copy link
Contributor

@JijoBose JijoBose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the ES-Lint warnings

@JijoBose JijoBose self-requested a review May 18, 2022 14:38
JijoBose
JijoBose requested changes May 18, 2022
View reviewed changes
Copy link
Contributor

@JijoBose JijoBose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the failing tests

@ajinkyaa
Copy link
Contributor Author

ajinkyaa commented May 19, 2022

@JijoBose resolved.

@ajinkyaa ajinkyaa merged commit 87a5c39 into develop May 19, 2022
@ajinkyaa ajinkyaa deleted the client-search-enhancement branch May 19, 2022 07:49
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
client search enhancements (#387)
b57977a 
* client search enhancements

* code optimized

* comments resolved

* removed extra code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JijoBose JijoBose JijoBose approved these changes

@apoorv1316 apoorv1316 Awaiting requested review from apoorv1316

Assignees

No one assigned

Labels

PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ajinkyaa @JijoBose