Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add unauthenticated action for client invoice view#388

Merged
rohitjoshixyz merged 1 commit intodevelopfrom
invoice-show
May 19, 2022
Merged

Add unauthenticated action for client invoice view#388
rohitjoshixyz merged 1 commit intodevelopfrom
invoice-show

Conversation

@rohitjoshixyz
Copy link
Contributor

@rohitjoshixyz rohitjoshixyz commented May 18, 2022 •
edited
Loading

Notion card

https://www.notion.so/Add-a-route-for-client-invoice-view-7c497f0103e94e359414605f64e5a2e4

Summary

Create a new controller under the invoices namespace called ViewController
Skip authentication for the show action as we want to open the client view of an invoice outside Miru as well (Using a link in Gmail)
Add a spec for unauthenticated action

Format of the added route is as getmiru.com/invoices/:id/view where :id is the invoice id

Preview

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@github-actions
Copy link

github-actions bot commented May 18, 2022

Current Code Coverage Percent of this PR:

94.47 %

Files having coverage below 100%

Impacted Files Coverage
/app/controllers/subscriptions_controller.rb 66.67 %
/app/controllers/invoices_controller.rb 63.64 %
/app/models/client.rb 92.68 %
/app/models/invoice.rb 96.3 %
/app/policies/subscriptions_policy.rb 66.67 %
/app/policies/timezone_policy.rb 66.67 %
/app/controllers/invoices/payments_controller.rb 61.11 %
/app/services/report/filters.rb 87.88 %
/app/services/invoice_payment/pdf_generation.rb 65.38 %
/app/services/invoice_payment/checkout.rb 43.48 %
/app/controllers/internal_api/v1/timezones_controller.rb 37.5 %
/lib/countries_info.rb 0.0 %

apoorv1316
apoorv1316 approved these changes May 19, 2022
View reviewed changes
Copy link
Collaborator

@apoorv1316 apoorv1316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rohitjoshixyz rohitjoshixyz merged commit bfc9ab7 into develop May 19, 2022
@rohitjoshixyz rohitjoshixyz deleted the invoice-show branch May 19, 2022 08:42
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
@rohitjoshixyz
Add unauthenticated action for client invoice view (#388)
f7d7dc3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apoorv1316 apoorv1316 apoorv1316 approved these changes

@akhilgkrishnan akhilgkrishnan Awaiting requested review from akhilgkrishnan

@shivamsinghchahar shivamsinghchahar Awaiting requested review from shivamsinghchahar

@sudeeptarlekar sudeeptarlekar Awaiting requested review from sudeeptarlekar

@apoorv-mishra apoorv-mishra Awaiting requested review from apoorv-mishra

Assignees

No one assigned

Labels

PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rohitjoshixyz @apoorv1316