Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Perf]Benchmark elasticsearch vs active record for large number of rows#391

Merged
supriya3105 merged 1 commit intodevelopfrom
filters-benchmark-es-vs-ar
May 20, 2022
Merged

[Perf]Benchmark elasticsearch vs active record for large number of rows#391
supriya3105 merged 1 commit intodevelopfrom
filters-benchmark-es-vs-ar

Conversation

@apoorv-mishra
Copy link
Contributor

@apoorv-mishra apoorv-mishra commented May 19, 2022

Notion card

NA

Summary

Preview

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@github-actions
Copy link

github-actions bot commented May 19, 2022 •
edited
Loading

Current Code Coverage Percent of this PR:

83.53 %

Files having coverage below 100%

Impacted Files Coverage
/app/controllers/subscriptions_controller.rb 66.67 %
/app/controllers/invoices_controller.rb 63.64 %
/app/models/invoice.rb 96.3 %
/app/models/client.rb 92.68 %
/app/policies/timezone_policy.rb 66.67 %
/app/policies/subscriptions_policy.rb 66.67 %
/app/controllers/invoices/payments_controller.rb 61.11 %
/app/services/report/filters.rb 87.88 %
/app/services/invoice_payment/checkout.rb 43.48 %
/app/services/invoice_payment/pdf_generation.rb 65.38 %
/app/controllers/internal_api/v1/timezones_controller.rb 37.5 %
/lib/benchmarking/benchmarker.rb 0.0 %
/lib/countries_info.rb 0.0 %

@apoorv-mishra apoorv-mishra force-pushed the filters-benchmark-es-vs-ar branch from 29b3605 to 1af521c Compare May 19, 2022 09:36
@apoorv-mishra apoorv-mishra force-pushed the filters-benchmark-es-vs-ar branch from 1af521c to 8ce9045 Compare May 19, 2022 12:19
@supriya3105 supriya3105 merged commit 1034654 into develop May 20, 2022
@supriya3105 supriya3105 deleted the filters-benchmark-es-vs-ar branch May 20, 2022 07:56
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
Benchmark elasticsearch vs active record (#391)
5f9558a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@supriya3105 supriya3105 supriya3105 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@apoorv-mishra @supriya3105