Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add wait_until option while generating pdf via grover#393

Merged
shalapatil merged 1 commit intodevelopfrom
fix-company-logo-on-invoice-pdf
May 23, 2022
Merged

Add wait_until option while generating pdf via grover#393
shalapatil merged 1 commit intodevelopfrom
fix-company-logo-on-invoice-pdf

Conversation

@shalapatil
Copy link
Contributor

@shalapatil shalapatil commented May 19, 2022 •
edited
Loading

Notion card

Summary

The company logo is rendering fine in PDF on local but not on production. To fix this, we are trying out the solution as per the Studiosity/grover#30.

Preview

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@github-actions
Copy link

github-actions bot commented May 19, 2022

Current Code Coverage Percent of this PR:

94.42 %

Files having coverage below 100%

Impacted Files Coverage
/app/controllers/subscriptions_controller.rb 66.67 %
/app/controllers/invoices_controller.rb 63.64 %
/app/models/invoice.rb 96.3 %
/app/models/client.rb 92.68 %
/app/policies/timezone_policy.rb 66.67 %
/app/policies/subscriptions_policy.rb 66.67 %
/app/controllers/invoices/payments_controller.rb 61.11 %
/app/services/invoice_payment/checkout.rb 43.48 %
/app/services/invoice_payment/pdf_generation.rb 66.67 %
/app/controllers/internal_api/v1/timezones_controller.rb 37.5 %
/lib/countries_info.rb 0.0 %

mohd-anas-ansari
mohd-anas-ansari approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@mohd-anas-ansari mohd-anas-ansari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would need to revert it back if it didn't work on the production.

@mohd-anas-ansari
Copy link
Contributor

mohd-anas-ansari commented May 19, 2022

In future, just in case:

@shalapatil shalapatil merged commit 65492dc into develop May 23, 2022
@shalapatil shalapatil deleted the fix-company-logo-on-invoice-pdf branch May 23, 2022 05:27
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
@shalapatil
Add wait_until option while generating pdf via grover (#393)
ef3ae0c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mohd-anas-ansari mohd-anas-ansari mohd-anas-ansari approved these changes

@akhilgkrishnan akhilgkrishnan Awaiting requested review from akhilgkrishnan

Assignees

No one assigned

Labels

PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shalapatil @mohd-anas-ansari