Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Multiple decimal value issue on client list page#394

Merged
supriya3105 merged 1 commit intodevelopfrom
fix-logged-hour-decimal-value
May 20, 2022
Merged

Multiple decimal value issue on client list page#394
supriya3105 merged 1 commit intodevelopfrom
fix-logged-hour-decimal-value

Conversation

@gowsik-ragunath
Copy link
Contributor

@gowsik-ragunath gowsik-ragunath commented May 20, 2022 •
edited
Loading

Notion card

https://www.notion.so/saeloun/Logged-hours-for-this-year-are-displayed-with-multiple-decimal-values-on-client-lists-page-ae6640c7085c4ccf9636ca5533e8af19

Summary

Truncated logged hour value to 2 decimal places on the client list page.

Preview

Screenshot 2022-05-20 at 10 31 05 AM

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • I have manually tested all workflows
  • I have performed a self-review of my own code
  • I have added automated tests for my code

@github-actions
Copy link

github-actions bot commented May 20, 2022

Current Code Coverage Percent of this PR:

94.47 %

Files having coverage below 100%

Impacted Files Coverage
/app/controllers/subscriptions_controller.rb 66.67 %
/app/controllers/invoices_controller.rb 63.64 %
/app/models/invoice.rb 96.3 %
/app/models/client.rb 92.68 %
/app/policies/timezone_policy.rb 66.67 %
/app/policies/subscriptions_policy.rb 66.67 %
/app/controllers/invoices/payments_controller.rb 61.11 %
/app/services/report/filters.rb 87.88 %
/app/services/invoice_payment/checkout.rb 43.48 %
/app/services/invoice_payment/pdf_generation.rb 65.38 %
/app/controllers/internal_api/v1/timezones_controller.rb 37.5 %
/lib/countries_info.rb 0.0 %

@supriya3105 supriya3105 merged commit d34b077 into develop May 20, 2022
@supriya3105 supriya3105 deleted the fix-logged-hour-decimal-value branch May 20, 2022 07:06
vipulnsward pushed a commit that referenced this pull request Feb 15, 2026
@gowsik-ragunath
Fixed the multiple decimal value issue in client list page (#394)
2ae27cb 
Co-authored-by: Gowsik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akhilgkrishnan akhilgkrishnan Awaiting requested review from akhilgkrishnan

@ajinkyaa ajinkyaa Awaiting requested review from ajinkyaa

@apoorv1316 apoorv1316 Awaiting requested review from apoorv1316

1 more reviewer

@supriya3105 supriya3105 supriya3105 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gowsik-ragunath @supriya3105