Thanks to visit codestin.com
Credit goes to github.com

Skip to content

update: generate iWork proto files with latest version of protoc #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 28, 2022
Merged

update: generate iWork proto files with latest version of protoc #107

merged 3 commits into from
Jun 28, 2022

Conversation

@helenamariano
Copy link
Contributor

@helenamariano helenamariano commented Jun 3, 2022 •
edited
Loading

Install:

brew install protoc
go install google.golang.org/protobuf/cmd/protoc-gen-go@latest

to generate go files from proto.

Run from iWork/pb-schema:

protoc -I=.  --go_out=paths=source_relative:./.. TSPArchiveMessages.proto
protoc -I=.  --go_out=paths=source_relative:./.. TSPDatabaseMessages.proto
protoc -I=.  --go_out=paths=source_relative:./.. TSPMessages.proto

@jkaho jkaho requested a review from jonathaningram June 14, 2022 02:57
jonathaningram
jonathaningram approved these changes Jun 14, 2022
View reviewed changes
Copy link
Member

@jonathaningram jonathaningram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As a followup change we could consider switching to buf for protobuf generation?

@jkaho jkaho marked this pull request as ready for review June 28, 2022 02:28
@jkaho jkaho merged commit 2894bd7 into master Jun 28, 2022
@jkaho jkaho deleted the ENG-3251/update_grpc_go branch June 28, 2022 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonathaningram jonathaningram jonathaningram approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@helenamariano @jonathaningram @jkaho