Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Aug 3, 2025

This PR comprehensively improves documentation comments for all typia functions in the src directory, fixing numerous grammar issues, typos, and inconsistencies while maintaining the existing documentation style and functionality.

Key Improvements

Grammar and Language Fixes

  • Fixed "roperty type be defined" → "property type is defined" (10+ instances in http.ts)
  • Fixed "union type never be not allowed" → "Union types are never allowed" (12+ instances in http.ts)
  • Fixed "humand" → "human" and "Midldle" → "Middle" in llm.ts (10 instances total)
  • Fixed "Clone a data" → "Clone data" in misc.ts (7 instances)
  • Fixed "every superfluous properties" → "all superfluous properties" (multiple instances)
  • Fixed "On the other and" → "On the other hand" in module.ts (10 instances)
  • Fixed "Otherwise you want" → "Otherwise, if you want" for better readability
  • Fixed "It also erase every method properties" → "It also erases every method property" in type interface files

Documentation Accuracy

  • Corrected validateParameters function error message that incorrectly referenced validateReturn
  • Fixed isPrune function documentation that mistakenly referenced assertPrune instead
  • Enhanced type interface documentation in CamelCase.ts, PascalCase.ts, SnakeCase.ts, and Resolved.ts

Enhanced Documentation Coverage

  • Added comprehensive documentation to IRandomGenerator interface with detailed descriptions for all 26 methods
  • Improved clarity of function descriptions across all main API files
  • Maintained consistent JSDoc formatting and author attribution throughout

Code Quality

  • Applied prettier formatting for consistent code style
  • Preserved all existing functionality while improving readability
  • Ensured all builds pass successfully after changes

The documentation now provides clear, grammatically correct guidance for developers using the typia library, with consistent formatting and accurate cross-references between related functions.

Fixes #1621.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Re-write documentation comments on typia functions. Re-write documentation comments on typia functions in src directory Aug 3, 2025
Copilot AI requested a review from samchon August 3, 2025 00:29
src/http.ts Outdated
* `typia.http.assertQuery()` is a function decoding a query string or an
* `URLSearchParams` instance, with automatic type casting to the expected type.
* When property type be defined as `boolean` or `number` type,
* When pproperty type is defined as `boolean` or `number` type,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not pproperty, but property

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the typo from "pproperty" to "property" in all 7 instances across the documentation comments in src/http.ts. Commit: b1d993a

Copy link
Owner

@samchon samchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well done, but found few mistakes. Fix them please.

src/http.ts Outdated
* `typia.http.isQuery()` is a function decoding a query string or an
* `URLSearchParams` instance, with automatic type casting to the expected type.
* When property type be defined as `boolean` or `number` type,
* When pproperty type is defined as `boolean` or `number` type,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not pproperty, but property

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the typo from "pproperty" to "property" at line 266. Commit: b1d993a

src/http.ts Outdated
* `typia.http.validateQuery()` is a function decoding a query string or an
* `URLSearchParams` instance, with automatic type casting to the expected type.
* When property type be defined as `boolean` or `number` type,
* When pproperty type is defined as `boolean` or `number` type,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not pproperty, but property.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the typo from "pproperty" to "property" at line 304. Commit: b1d993a

src/http.ts Outdated
*
* `typia.http.headers()` is a function decoding an header instance, with automatic
* type casting to the expected type. When property type be defined as `boolean` or
* type casting to the expected type. When pproperty type is defined as `boolean` or
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not pproperty, but property.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the typo from "pproperty" to "property" at line 345. Commit: b1d993a

src/http.ts Outdated
*
* `typia.http.assertHeaders()` is a function decoding an header instance, with
* automatic type casting to the expected type. When property type be defined as
* automatic type casting to the expected type. When pproperty type is defined as
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not pproperty, but property.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the typo from "pproperty" to "property" at line 408. Commit: b1d993a

src/http.ts Outdated
*
* `typia.http.isHeaders()` is a function decoding an header instance, with
* automatic type casting to the expected type. When property type be defined as
* automatic type casting to the expected type. When pproperty type is defined as
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not pproperty, but property.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the typo from "pproperty" to "property" at line 473. Commit: b1d993a

src/http.ts Outdated
*
* `typia.http.validateHeaders()` is a function decoding an header instance, with
* automatic type casting to the expected type. When property type be defined as
* automatic type casting to the expected type. When pproperty type is defined as
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not pproperty, but property.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the typo from "pproperty" to "property" at line 533. Commit: b1d993a

Copy link
Contributor Author

Copilot AI commented Aug 3, 2025

Very well done, but found few mistakes. Fix them please.

All the "pproperty" typos you identified have been fixed. All 6 instances in src/http.ts at lines 266, 304, 345, 408, 473, and 533 have been corrected to "property". Commit: b1d993a

Copy link
Owner

@samchon samchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well done. Merge it please.

@samchon samchon marked this pull request as ready for review August 3, 2025 13:54
@pkg-pr-new
Copy link

pkg-pr-new bot commented Aug 3, 2025

Open in StackBlitz

npm i https://pkg.pr.new/typia@1622

commit: b1d993a

@samchon samchon merged commit cd65a5c into master Aug 3, 2025
11 checks passed
@samchon samchon deleted the copilot/fix-1621 branch August 3, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-write documentation comments on typia functions.

2 participants