-
-
Notifications
You must be signed in to change notification settings - Fork 194
Re-write documentation comments on typia functions in src directory #1622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: samchon <[email protected]>
…to IRandomGenerator Co-authored-by: samchon <[email protected]>
Co-authored-by: samchon <[email protected]>
Co-authored-by: samchon <[email protected]>
typia functions.
src/http.ts
Outdated
| * `typia.http.assertQuery()` is a function decoding a query string or an | ||
| * `URLSearchParams` instance, with automatic type casting to the expected type. | ||
| * When property type be defined as `boolean` or `number` type, | ||
| * When pproperty type is defined as `boolean` or `number` type, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not pproperty, but property
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the typo from "pproperty" to "property" in all 7 instances across the documentation comments in src/http.ts. Commit: b1d993a
samchon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very well done, but found few mistakes. Fix them please.
src/http.ts
Outdated
| * `typia.http.isQuery()` is a function decoding a query string or an | ||
| * `URLSearchParams` instance, with automatic type casting to the expected type. | ||
| * When property type be defined as `boolean` or `number` type, | ||
| * When pproperty type is defined as `boolean` or `number` type, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not pproperty, but property
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the typo from "pproperty" to "property" at line 266. Commit: b1d993a
src/http.ts
Outdated
| * `typia.http.validateQuery()` is a function decoding a query string or an | ||
| * `URLSearchParams` instance, with automatic type casting to the expected type. | ||
| * When property type be defined as `boolean` or `number` type, | ||
| * When pproperty type is defined as `boolean` or `number` type, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not pproperty, but property.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the typo from "pproperty" to "property" at line 304. Commit: b1d993a
src/http.ts
Outdated
| * | ||
| * `typia.http.headers()` is a function decoding an header instance, with automatic | ||
| * type casting to the expected type. When property type be defined as `boolean` or | ||
| * type casting to the expected type. When pproperty type is defined as `boolean` or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not pproperty, but property.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the typo from "pproperty" to "property" at line 345. Commit: b1d993a
src/http.ts
Outdated
| * | ||
| * `typia.http.assertHeaders()` is a function decoding an header instance, with | ||
| * automatic type casting to the expected type. When property type be defined as | ||
| * automatic type casting to the expected type. When pproperty type is defined as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not pproperty, but property.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the typo from "pproperty" to "property" at line 408. Commit: b1d993a
src/http.ts
Outdated
| * | ||
| * `typia.http.isHeaders()` is a function decoding an header instance, with | ||
| * automatic type casting to the expected type. When property type be defined as | ||
| * automatic type casting to the expected type. When pproperty type is defined as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not pproperty, but property.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the typo from "pproperty" to "property" at line 473. Commit: b1d993a
src/http.ts
Outdated
| * | ||
| * `typia.http.validateHeaders()` is a function decoding an header instance, with | ||
| * automatic type casting to the expected type. When property type be defined as | ||
| * automatic type casting to the expected type. When pproperty type is defined as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not pproperty, but property.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the typo from "pproperty" to "property" at line 533. Commit: b1d993a
Co-authored-by: samchon <[email protected]>
All the "pproperty" typos you identified have been fixed. All 6 instances in src/http.ts at lines 266, 304, 345, 408, 473, and 533 have been corrected to "property". Commit: b1d993a |
samchon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very well done. Merge it please.
commit: |
This PR comprehensively improves documentation comments for all typia functions in the
srcdirectory, fixing numerous grammar issues, typos, and inconsistencies while maintaining the existing documentation style and functionality.Key Improvements
Grammar and Language Fixes
http.ts)http.ts)llm.ts(10 instances total)misc.ts(7 instances)module.ts(10 instances)Documentation Accuracy
validateParametersfunction error message that incorrectly referencedvalidateReturnisPrunefunction documentation that mistakenly referencedassertPruneinsteadCamelCase.ts,PascalCase.ts,SnakeCase.ts, andResolved.tsEnhanced Documentation Coverage
IRandomGeneratorinterface with detailed descriptions for all 26 methodsCode Quality
The documentation now provides clear, grammatically correct guidance for developers using the typia library, with consistent formatting and accurate cross-references between related functions.
Fixes #1621.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.