Suppoer transform options in playground website #1652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces customizable TypeScript transform options to the playground website, allowing users to configure transformation settings through a UI dialog. The changes enable users to adjust options like finite, numeric, functional, and undefined validation behaviors directly from the playground interface.
- Adds a new
OptionsModalcomponent with UI controls for transform options - Refactors the compiler service interface to accept options alongside source code
- Renames
OutputViewertoResultViewerfor better clarity
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| website/src/movies/PlaygroundMovie.tsx | Integrates options modal, updates state management for transform options, and refactors compiler service calls |
| website/src/components/playground/ResultViewer.tsx | Renames component from OutputViewer to ResultViewer |
| website/src/components/playground/OptionsModal.tsx | New modal component for configuring transform options with form controls |
| website/src/compiler/index.ts | Updates compiler service implementation to accept and use transform options |
| website/src/compiler/ICompilerService.ts | Refactors interface to use props object and renames output types |
| website/package.json | Bumps typedoc dependency version |
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for customizable TypeScript transform options in the playground UI, allowing users to adjust transformation settings through a new modal dialog. It also refactors the compiler service interface and related code to handle these options throughout the compile/transform/bundle flow. Additionally, it renames the output viewer component for clarity and updates dependencies.
Support for customizable transform options in the playground:
OptionsModalcomponent (OptionsModal.tsx) that lets users adjust TypeScript transform options (finite, numeric, functional, undefined) via a UI dialog. This modal is integrated into the playground and can be opened with a settings button. [1] [2] [3]ITransformOptions, ensuring that compile and transform actions use the selected options. [1] [2]Refactoring of compiler service interface and usage:
ICompilerServiceto accept apropsobject containing bothsourceand optionaloptions, and renamed output types fromIOutputtoIResultfor clarity. All calls to the compiler service now use this new interface. [1] [2] [3] [4] [5] [6]Component renaming and code clarity:
OutputViewercomponent toResultViewerfor improved clarity and updated all references accordingly. [1] [2] [3] [4]Dependency updates:
typedocdependency from0.28.8to0.28.9inpackage.json.