Use npm's trusted publisher instead #1694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR transitions from manual provenance attestation to npm's trusted publisher feature for automated provenance generation. The changes streamline the deployment process while maintaining package integrity through GitHub Actions OIDC authentication.
- Removes the
--provenanceflag from the npm publish command for thelatesttag inDeployRunner.ts - Adds explicit package manager specification
[email protected]topackage.jsonfor consistent dependency management
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| deploy/internal/DeployRunner.ts | Simplifies npm publish command by removing conditional --provenance flag, relying on automated trusted publisher |
| package.json | Adds packageManager field specifying [email protected] for environment consistency |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a couple of small but important updates related to deployment and package management. The main changes are a simplification of the npm publish command in the deployment script and the specification of the package manager in
package.json.Deployment process update:
npm publishcommand inDeployRunner.tsno longer includes the--provenanceflag for thelatesttag, streamlining the deployment process.Package management update:
package.jsonnow explicitly specifies[email protected]as the package manager, which helps ensure consistent dependency management across environments.