feature/request-body-handling: Configurable request body #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erisean
approved these changes
Jul 18, 2024
| case .jsonEncodable(let encodable): | ||
| let jsonData = try? JSONEncoder().encode(encodable) | ||
| urlRequest.httpBody = jsonData | ||
| } |
Collaborator
There was a problem hiding this comment.
You could consider adding some code in here as well to automatically add Content-Type header to the urlRequest depending on the body type if the user doesn't manually add it
samgilmore
added a commit
that referenced
this pull request
Jul 25, 2024
* Add basic GET function * Create network/request protocols and implementations (#2) * Create basic protocols and implementations Added network and request protocols as well as base implementations for each. * Condense enum + abstract URLRequest * Convert URLSession to stored variable * Abstract configuration into enum * feature/request-body-handling: Configurable request body (#3) * Allow for data model in body * Add default content-type header * Add retry and timeout logic (#4) * Add basic caching (#5) * epic/cookie-management: Implement Cookie Management Operations and Request Configuration (#6) * Implement Cookie Management * Refactor into CookieManager * Refactor Request + Private UD * Add Request cookie method * Implement batch requests (#7)
samgilmore
added a commit
that referenced
this pull request
Jul 25, 2024
* Add basic GET function * Create network/request protocols and implementations (#2) * Create basic protocols and implementations Added network and request protocols as well as base implementations for each. * Condense enum + abstract URLRequest * Convert URLSession to stored variable * Abstract configuration into enum * feature/request-body-handling: Configurable request body (#3) * Allow for data model in body * Add default content-type header * Add retry and timeout logic (#4) * Add basic caching (#5) * epic/cookie-management: Implement Cookie Management Operations and Request Configuration (#6) * Implement Cookie Management * Refactor into CookieManager * Refactor Request + Private UD * Add Request cookie method * Implement batch requests (#7) * Add docstrings + inline comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows the user to easily set the body of a request as either a String, a Data object, or a Swift model of their choosing that conforms to Encodable.