Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Tags: samwgoldman/folly

Tags

v2022.07.25.00

Toggle v2022.07.25.00's commit message
Fix build without SSE 4.2

Summary: The addition of base64 broke the builds.

Differential Revision: D38018543

fbshipit-source-id: adfee514e235ec23db4a7b3a889fd0c1c8e40343

v2022.07.18.00

Toggle v2022.07.18.00's commit message
Remove fibers::ExecutionObserver::runnable

Summary:
`runnable` callback was added to fibers ExecutionObserver in D2081306
to measure fiber execution latency. Since then, not a single meaningful user of
this API exists.

On the other hand, the way `runnable` callback is implemented, opens
possibility for race conditions (Fiber::fiberManager_ is being accessed from
multiple threads without synchronization).

There is no easy way to preserve semantics of this callback while guaranteeing
thread safety and not hurting performance, so as the alternative let's remove
the feature altogether.

Reviewed By: yfeldblum

Differential Revision: D37804391

fbshipit-source-id: 70a191bcd2628fa484c2243af21dc237a8746701

v2022.07.11.00

Toggle v2022.07.11.00's commit message
cut exception_wrapper::from_exception_ptr

Summary: Since it is equivalent to the `folly::exception_wrapper` constructor taking `std::exception_ptr`.

Reviewed By: Orvid, luciang

Differential Revision: D28249473

fbshipit-source-id: 32a5c4e4fcfc8ebccd9d7530a41bd41460f82a04

v2022.07.04.00

Toggle v2022.07.04.00's commit message
ConcurrentHashMap-detail.h: remove code for set-but-unused count (fac…

…ebook#1806)

Summary:
Pull Request resolved: facebook#1806

"count" was set but never used.
Remove it.

Differential Revision: D37500239

fbshipit-source-id: e05034df762b7a15312ffd6c981bf5b3531fe14c

v2022.06.27.00

Toggle v2022.06.27.00's commit message
Allow building of EliasFanoCoding on aarch64 too

Summary: Allow building of EliasFanoCoding on aarch64 too

Reviewed By: philippv

Differential Revision: D37444695

fbshipit-source-id: 51caf78b9c7401a3ef3620bbb0f23d53e36124c5

v2022.06.20.00

Toggle v2022.06.20.00's commit message
Revert D33783486: Multisect successfully blamed D33783486 for test or…

… build failures

Summary:
This diff is reverting D33783486 (facebook@7d1b6c7)
D33783486 (facebook@7d1b6c7) has been identified to be causing the following test or build failures:
Tests affected:
- https://www.internalfb.com/intern/test/844424947191811/
- https://www.internalfb.com/intern/test/844424947191810/
- https://www.internalfb.com/intern/test/281475027627500/

Here's the Multisect link:
https://www.internalfb.com/intern/testinfra/multisect/977558
Here are the tasks that are relevant to this breakage:
T123390000: 6 tests started failing for oncall workflows_oncall in the last 2 weeks
We're generating a revert to back out the changes in this diff, please note the backout may land if someone accepts it.

Reviewed By: nanshu

Differential Revision: D37137990

fbshipit-source-id: 51de48d9eafe4d71b832f5614a2675d368e497e1

v2022.06.13.00

Toggle v2022.06.13.00's commit message
tweaks to importing cython-generated modules

Summary:
* Address data-race on `static bool` local variable.
* Add comments describing why optimistic concurrency is necessary and why the cxxabi mutex is to be avoided.

Reviewed By: pranavtbhat

Differential Revision: D36921157

fbshipit-source-id: 519034db0b0db10f0b0dbf0620729b271443ebfa

v2022.06.06.00

Toggle v2022.06.06.00's commit message
Back out "Clamp small_vector capacity at maximum size."

Summary: The diff D36818796 (facebook@6695e49) cause some SL regressions in multifeed_aggregator

Differential Revision: D36928263

fbshipit-source-id: 57dee7b316e257e82d4f4eafb62bb853a0805763

v2022.05.30.00

Toggle v2022.05.30.00's commit message
add missing sanitizer suppression in MicroLock

Summary:
`MicroLock` has 1 byte of state but operates on the containing aligned 4-byte word, principally because the linux `futex` syscall which backs it operates on the containing aligned 4-byte word.

This means that every operation which loads or stores this word must be done in a context with sanitizers suppressed.

Differential Revision: D36738948

fbshipit-source-id: 755d9557068d2efa9a74a9dd767a9fa5b3662d0c

v2022.05.23.00

Toggle v2022.05.23.00's commit message
work around gcc-12 + CWG 903 in FOLLY_SAFE_CHECK (facebook#1777)

Summary:
- it is workaround CWG 903 in gcc-12, which is considering `int{}`  as null pointer constant, and so can't choose between `safe_assert_msg_types_one(uint64_t)` and `safe_assert_msg_types_one(char const *)`
- see https://godbolt.org/z/fov5xPjEe

previously landed in {D36458136 (facebook@68ea0c2)}, which triggered some unknown bug and was reverted

closes facebook#1772

Pull Request resolved: facebook#1777

Test Plan:
Imported from GitHub, without a `Test Plan:` line.

  buck2 test folly/lang/test:safe_assert_test
  buck build fbsource//fbandroid/mode/server fbsource//fbandroid/mode/opt fbsource//fbandroid/apps/assistantplayground:assistantplayground_release

Reviewed By: Orvid

Differential Revision: D36552302

Pulled By: yfeldblum

fbshipit-source-id: 2bc00d2e6b893c2192c7071bbc859df73924c6f5