Hardhat table #329
Merged
Hardhat table #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a. A builder cannot get a hardhat if they already have a tool checked out (may be too broad) b. No two checkouts can be active for the same tool.
jmmclaug201
requested changes
Feb 23, 2025
app/views/tools/index.html.erb
Outdated
| <%= link_to 'Radio', tools_path(type: 'radio') %> | ||
| </li> | ||
| </ul> | ||
| </div> |
There was a problem hiding this comment.
I would rethink the UX here a little bit; binder.springcarnival.org/tools currently has a broken version of this as a dropdown menu, I think you could take inspiration from this (maybe don't include the "checked out status" dropdown though)
There was a problem hiding this comment.
…ge look, fix index with new abilities, make index page load faster
|
I think my rebase may not have been the best idea.. Should probably study github again. Sorry for the massive ammount of commits |
jmmclaug201
approved these changes
Mar 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a way to change tool table to show different types of tool (tool, hardhat, radio). Probably could have better use of language.
