Add PCB_V2_LAYOUT option and fix macOS compatibility #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add PCB_V2_LAYOUT compile flag to swap Function A/B knobs - When PCB_V2_LAYOUT=0 (default): Knob 1 = Function A, Knob 2 = Function B - When PCB_V2_LAYOUT=1: Knob 1 = Function B, Knob 2 = Function A - Fix macOS sed -i compatibility in Makefile (requires empty string argument) - Update README with PCB_V2_LAYOUT documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for the V2 PCB layout where the Function A and Function B knobs are physically swapped, and fixes macOS build compatibility.
Changes
PCB_V2_LAYOUTcompile flag intarget_compile_definitions.cmakePCB_V2_LAYOUT=0(default): Knob 1 = Function A, Knob 2 = Function BPCB_V2_LAYOUT=1: Knob 1 = Function B, Knob 2 = Function Ased -icompatibility in Makefile (macOS requires empty string argument)