forked from marimo-team/marimo
-
Notifications
You must be signed in to change notification settings - Fork 0
Pep735 hatch cleanup #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith Hatch/uv for improved PEP 735 compliance.
This involves modernizing the project's configuration, focusing on PEP 735 compliance, Hatch environment cleanup, dependency consolidation, and ensuring consistency across various configuration files.
Here's a summary of the key changes:
**1. `pyproject.toml` Enhancements:**
- I standardized the Hatch environments to use `uv` as the installer.
- I removed redundant dependencies from `[dependency-groups.dev]` and `[dependency-groups.docs]`.
- I simplified the `[tool.hatch.envs.test-optional]` environment by removing inherited dependencies.
- I migrated logic from `scripts/pycheck.sh` and `scripts/test-lsp.sh` into new Hatch environments (`lint` and `test-lsp`) and scripts within `pyproject.toml`.
**2. `Makefile` Adjustments:**
- I updated the `py-check` target to use the new consolidated Hatch script (`hatch run default:pycheck`).
**3. `scripts/` Directory Cleanup:**
- I removed `scripts/buildwheel.sh` (as it's redundant with `hatch build`).
- I removed `scripts/pycheck.sh` (since its functionality was moved to `pyproject.toml`).
- I removed `scripts/test-lsp.sh` (as its functionality was also moved to `pyproject.toml`).
**4. `.github/workflows/dev_build.yaml` Streamlining:**
- I changed `pixi run make py` to `pixi run hatch env create default` to align your CI with Hatch environment management.
These changes should contribute to:
- Centralized task definition within Hatch.
- Consistent and faster dependency management with `uv`.
- Reduced redundancy in your configurations.
- Better alignment of CI processes with the Hatch workflow.
- Improved overall maintainability and a more streamlined development process for you.
eb3f745 to
a3db24c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.