TST:CI: Make some improvements to data driven tests #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only one type overload was tested for each function. This PR adds tests for each overload that is tested in scipy special's tests. It also changes CI to use an out of source build, and makes adjustments to CMakeLists.txt to ensure target names for tests remain unique even if multiple subfolders in
xsf/testsend up with test files with the same name.Missing float overloads are added for
chdtrandchdtrc. There are more missing overloads inxsf/stats.hbut I've only added those needed to get all tests to pass. I've also added a little more wiggle room to the test tolerances. Now a test passes if the (extended) relative error is no more than 4x that allowed in the reference. There was one case forairythat was failing by a very small amount with a very tight tolerance. I'm trying to avoid situations where we find ourselves having to bump tolerances due to flaky tests.