-
Couldn't load subscription status.
- Fork 3
Configure Mantid's logger #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Done. I postponed doing anything in scippneutron until we are happy with the setup in ess. We didn't like having to call a config function manually. And I don't think anything has changed. |
|
Do i remember correctly that getting rid of the config step would probably be solved by a workflow builder/manager or something like it? |
| }, | ||
| "outputs": [], | ||
| "source": [ | ||
| "_ = configure_workflow('sans2d_I_of_Q', filename='sans2d.log')" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "_ = configure_workflow('sans2d_I_of_Q', filename='sans2d.log')" | |
| "logger = configure_workflow('sans2d_I_of_Q', filename='sans2d.log')" |
Would be a bit less cryptic? (This is how it's done in the Amor notebook)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. It is unused, though.
If we end up implementing a manager, yes. |
With Mantid 6.4, we can now capture Mantid's log messages and display them along our logs. This should fix the problem of messages not showing sometimes.
If an older version of Mantid is installed, the configuration will work as before and not touch Mantid.