Update to scipp0.16 #138
Merged
Update to scipp0.16 #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jl-wynen
reviewed
Aug 29, 2022
.buildconfig/ci.yml
Outdated
| - scippneutron=0.8.0 | ||
| - scippnexus=0.1.7 | ||
| - scipp=0.16.2 | ||
| - scippneutron=0.9.1 |
There was a problem hiding this comment.
Let's wait for scippneutron 0.9.2 (building now)
| from scippneutron.tof import conversions | ||
| from scippneutron.core.conversions import _elem_dtype, _elem_unit | ||
| from scippneutron.conversion.graph import beamline, tof | ||
| from scippneutron._utils import elem_dtype, elem_unit |
There was a problem hiding this comment.
We need a proper way of exposing these! (This is a comment about scipp...)
There was a problem hiding this comment.
I am wondering once more whether dtype and unit should just forward to the elem dtype and unit? There are several questions:
- What to do for
Datasetbuffer? There is not uniquedtypeandunitin this case.unitcould beNone. - How to get the buffer type, if not via
dtype? - Is there code that will break, and why?
src/ess/sans/conversions.py
Outdated
| from scippneutron._utils import elem_unit | ||
|
|
||
| # from scippneutron.tof import conversions | ||
| # from scippneutron.core.conversions import _elem_unit |
jl-wynen
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are mainly due to coordinate transformation graphs having been moved to a new location in
scippneutron.