Ditch mantid from CI #208
Merged
Ditch mantid from CI #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonHeybrock
approved these changes
Sep 15, 2023
Comment on lines
+23
to
+25
| 'PG3_4844_event.zip': 'md5:a644c74f5e740385469b67431b690a3e', | ||
| 'PG3_4866_event.zip': 'md5:5bc49def987f0faeb212a406b92b548e', | ||
| 'PG3_FERNS_d4832_2011_08_24.zip': 'md5:0fef4ed5f61465eaaa3f87a18f5bb80d', |
There was a problem hiding this comment.
Interesting, how much of a difference does this make?
There was a problem hiding this comment.
For the largest (vana, 4866), a 3x size reduction from 1.5GiB.
Yes, should be done separately, if at all. We may need Mantid for some sub packages it switching away from conda would make that harder in the future. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the struggle in #206 and that I need Scipp 23.08.0 for #203, this PR removes Mantid from the CI builds.
There still are calls to
scn.loadin the loki and imaging modules. But they import Mantid only when called. And they don't seem to get called anywhere.