Add plopp to installation environments #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jl-wynen
reviewed
Oct 2, 2023
docs/environments/ess-mantid.yml
Outdated
| - jupyterlab_widgets | ||
| - plopp | ||
| - pythreejs | ||
| - scipp<23.08.0 # TODO: remove version pin when mantid and scipp have compatible versions of TBB |
There was a problem hiding this comment.
Is this needed? Can't conda resolve to a compatible version automatically?
There was a problem hiding this comment.
Actually it does. I'm not sure why I thought we needed this. Wojciech said he ran into the issue. I'll remove.
There was a problem hiding this comment.
Did he make an env from scratch? It could be that it fails to resolve when you install into an existing env.
jl-wynen
approved these changes
Oct 2, 2023
|
Flaky macos docs build failed. Other builds fine. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.