Merged
Conversation
AFAIK, there is no need to keep all coords around. And this caused a problem in Scipp where the averaging introduced in 649064e fails for a datetime coord.
nvaytet
reviewed
May 19, 2025
| """ | ||
| out = to_data_array(obj) | ||
| if isinstance(coords, str): | ||
| coords = [coords] |
Member
There was a problem hiding this comment.
I think this means that the check
if isinstance(coords, str):
coords = [coords]further down (L231) can be removed?
| da = data_array(ndim=2) | ||
| da.coords['xx2'] = 7.5 * da.coords['xx'] | ||
| da.coords['yy2'] = 3.3 * da.coords['yy'] | ||
| out = preprocess(da, coords=['yy2', 'xx']) |
Member
There was a problem hiding this comment.
Also test the case where the arg passed as coords is a string?
e.g. preprocess(da, coords='yy2')
nvaytet
approved these changes
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AFAIK, there is no need to keep all coords around. And this caused a problem in Scipp where the averaging introduced in #428 fails for a datetime coord. (See scipp/scipp#3695)