Major feature: Suites #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
Owner
Author
|
Ready to merge. |
Owner
Author
|
Less sure about this after more consideration. The same thing could be achieved with a single // file 1
var suite = spec.New("my suite", myreporter)
var runTestObject = suite("test object", testObject)
func TestObject(t *testing.T) { runTestObject(t) }
func testObject(t *testing.T, when spec.G, it spec.S) {
...
}
// file 2
var runTestOtherObject = suite("test other object", testOtherObject)
func TestOtherObject(t *testing.T) { runTestOtherObject(t) }
func testOtherObject(t *testing.T, when spec.G, it spec.S) {
...
}(Also could use By looking up the // file 1
var suite spec.Suite
func init() {
suite = spec.New("my suite", myreporter)
suite("TestObject", testObject)
suite("TestOtherObject", testOtherObject)
}
func TestObject(t *testing.T) { suite.Run(t) }
func testObject(t *testing.T, when spec.G, it spec.S) {
...
}
// file 2
func TestOtherObject(t *testing.T) { suite.Run(t) }
func testOtherObject(t *testing.T, when spec.G, it spec.S) {
...
}Which could also look like: // file 1
var suite = spec.New("my suite", myreporter)
func init() {
suite("TestObject", testObject)
}
func TestObject(t *testing.T) { suite.Run(t) }
func testObject(t *testing.T, when spec.G, it spec.S) {
...
}
// file 2
func init() {
suite("TestOtherObject", testOtherObject)
}
func TestOtherObject(t *testing.T) { suite.Run(t) }
func testOtherObject(t *testing.T, when spec.G, it spec.S) {
...
}Or maybe: // file 1
var suite = spec.New("my suite", myreporter)
func init() {
suite("TestObject", func(t *testing.T, when spec.G, it spec.S) {
...
})
}
func TestObject(t *testing.T) { suite.Run(t) }
// file 2
func init() {
suite("TestOtherObject", func(t *testing.T, when spec.G, it spec.S) {
...
})
}
func TestOtherObject(t *testing.T) { suite.Run(t) } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Options global (e.g., test order)Note: this is an untested prototypeUsage:
Or better: