Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix corrupt trees when the ostringstream is full #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 4, 2015
Merged

Fix corrupt trees when the ostringstream is full #77

merged 5 commits into from
Jun 4, 2015

Conversation

@paulstaab
Copy link
Member

  • save each tree in a separate string
  • adds error messages for stringstreams

fixes #76

@paulstaab paulstaab added the bug label Jun 4, 2015
@paulstaab paulstaab added this to the Version 1.6.0 milestone Jun 4, 2015
@paulstaab
Copy link
Member Author

Command Equal results time master time fix/issue_76 memory master memory fix/issue_76
scrm 100 100 -t 5 -T Yes 0.1s 0.1s 3131kb 3190kb
scrm 20 100 -r 10 100 -t 3 -T -L Yes 0.072s 0.075s 3209kb 3168kb
scrm 4 10000 -r 10 100 -t 5 Yes 0.54s 0.53s 3052kb 3041kb
scrm 20 2 -r 500 100 -L Yes 0.15s 0.15s 3198kb 3201kb
scrm 2000 1 -r 10 100 -l 50 -L Yes 0.5s 0.5s 3376kb 3374kb
scrm 20 1 -r 4000 10000000 -l 300000 -T Yes 0.87s 0.85s 18103kb 11929kb
scrm 10 100 -r 10 100 -I 3 3 3 4 0.5 -eN 0.1 0.05 -eN 0.2 0.5 -L Yes 0.055s 0.054s 3112kb 3115kb
scrm 50 100 -r 20 200 -G 1.5 -l 100 -L Yes 0.048s 0.046s 3145kb 3144kb

paulstaab added a commit that referenced this pull request Jun 4, 2015
@paulstaab
Merge pull request #77 from scrm/fix/issue_76
e401eee 
Fix corrupt trees when the ostringstream is full
@paulstaab paulstaab merged commit e401eee into master Jun 4, 2015
@paulstaab paulstaab deleted the fix/issue_76 branch June 4, 2015 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

Version 1.6.0

Development

Successfully merging this pull request may close these issues.

Newick Trees are incomplete in very rare cases

1 participant

@paulstaab