-
Notifications
You must be signed in to change notification settings - Fork 6
Open
Labels
help wantedExtra attention is neededExtra attention is needed
Description
Right now, this line is commented out. We should figure out a way to enable icu for this project :)
The old chromium source of icu has this commented out probably because the third_party library ICU is difficult to configure. However, because the idna block of code in chromium source is commented out, the idna hostname, for example: ουτοπία.δπθ.gr is not converted to the ascii form.
At the moment, we have this handled by encoding the hostname with python encode() function, this can be seen here. However, it would be really nice to improve the performance of SCURL by figuring out how to use ICU in chromium source!
Metadata
Metadata
Assignees
Labels
help wantedExtra attention is neededExtra attention is needed