v3.0.1 #83
Merged
v3.0.1 #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When applying commit 1b86b1d, the indentation of the 'ProjectConf' class was messed up. This is fixed by reducing the indentation width for this part of the code. Signed-off-by: Claus Hunsen <[email protected]>
After the landing of se-sic/codeface-extraction#6, we can add committer data to the resulting data.frame of the commit data source. This includes "committer.date", "committer.name", and "committer.email", where the committer date is consequently converted to POSIXct. The data is also available as edge attribute through the network configuration. When reading data from disk and no committer data is available in the original data, we adaptively add NAs for it. This fixes #35. This change also needs to be backported to v3.0. Signed-off-by: Claus Hunsen <[email protected]>
Analogously to 251cfdb, we no longer give the expected number of expected columns in the author data as hard- coded number, but rather through the number of column names to be set. This makes the code more reliable and will also improve future addenda. Signed-off-by: Claus Hunsen <[email protected]>
We should only give warning about non-existent data for splittable data (i.e., commits, mails, issues), but not for others (i.e., PaStA and synchronicity data). This way, the user does not get confused by the warning, especially, if the data is only attempted to read during splitting, but is not really used. Thanks to @bockthom and originally @Angelika1 for reporting this. Signed-off-by: Claus Hunsen <[email protected]>
After 251cfdb, this patch fixes the test suite by setting dummy committer data. This data should be tested later more accurately. Signed-off-by: Claus Hunsen <[email protected]>
To enable everybody to reliably delete isolate vertices from a network, we introduce the function 'delete.isolates'. In addition, the extraction functions for multi-network views now have a parameter 'remove.isolates' to trigger exactly this functionality. Signed-off-by: Claus Hunsen <[email protected]> Signed-off-by: Thomas Bock <[email protected]>
To better distinguish project and network configuration, the log message in the project-configuration initializer is slightly updated. Add a FIXME item regarding the 'Conf$check.values()' call in the initializer. Signed-off-by: Claus Hunsen <[email protected]>
Small improvements for v3.0 Reviewed-by: Thomas Bock <[email protected]>
clhunsen
approved these changes
Dec 20, 2017
Collaborator
clhunsen
left a comment
There was a problem hiding this comment.
No changes from the merge to dev, so this is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we move some small fixes for
v3.0from thedevbranch to themasterbranch, denoting releasev3.0.1.