fix: build tag parsing. #1413
Open
fix: build tag parsing. #1413
+207
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please could you fix the lint warnings? |
ccojocar
reviewed
Nov 4, 2025
| trackSuppressions bool | ||
| concurrency int | ||
| analyzerSet *analyzers.AnalyzerSet | ||
| mu sync.Mutex |
There was a problem hiding this comment.
Why was required to remove this mutex? How is related to this change?
| // step 2/2: pass in cli encoded build flags to build correctly. | ||
| conf := &packages.Config{ | ||
| Mode: LoadMode, | ||
| BuildFlags: CLIBuildTags(buildTags), |
There was a problem hiding this comment.
Ins't this the only fix required to get properly the build flags propagated? Why's the reason for the extended refactoring?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to fix #1412
Couple of thoughts:
load()take in bothbuildTagsand a*package.Configso it's only processed and in memory once.SampleCodeBuildTag=>SampleCodeCompilationFailand addedshould not panic if a file can not compileas a test case